Fix a MarkerRef call to get the active bookmark in Mercurial
ClosedPublic
Actions

Authored by epriestley on Jul 6 2020, 9:06 PM.

Tags

None

Referenced Files

	F15335614: D21391.diff
	Sat, Mar 8, 4:55 PM

	F15335425: D21391.id.diff
	Sat, Mar 8, 3:08 PM

	F15334130: D21391.id50918.diff
	Sat, Mar 8, 6:56 AM

	F15285404: D21391.id50919.diff
	Tue, Mar 4, 1:28 PM

	Unknown Object (File)
	Jan 20 2025, 12:27 PM

	Unknown Object (File)
	Jan 20 2025, 12:26 PM

	Unknown Object (File)
	Jan 20 2025, 12:26 PM

	Unknown Object (File)
	Jan 19 2025, 11:36 AM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rARCe2ac83ce572c: (stable) Fix a MarkerRef call to get the active bookmark in Mercurial
rARC79a6dfd7a99f: Fix a MarkerRef call to get the active bookmark in Mercurial

Summary

See PHI1805. This call is constructed improperly and can lead to a fatal in arc patch under Mercurial.

Test Plan

In Mercurial, ran a valid arc patch operation.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jul 6 2020, 9:06 PM

Harbormaster completed remote builds in B24737: Diff 50918.Jul 6 2020, 9:06 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 6 2020, 9:06 PM

epriestley requested review of this revision.

Closed by commit rARC79a6dfd7a99f: Fix a MarkerRef call to get the active bookmark in Mercurial (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC79a6dfd7a99f: Fix a MarkerRef call to get the active bookmark in Mercurial.

epriestley added a commit: rARCe2ac83ce572c: (stable) Fix a MarkerRef call to get the active bookmark in Mercurial.

Revision Contents
Changeset List

Path

Size

src/

repository/

api/

ArcanistMercurialAPI.php

5 lines

Diff 50919

View Options

src/repository/api/ArcanistMercurialAPI.php

Fix a MarkerRef call to get the active bookmark in MercurialClosedPublicActions