Differential D21390

Render the state tree in "arc branches" slightly more cleanly
ClosedPublic
Actions

Authored by epriestley on Jul 3 2020, 6:39 PM.

Details

Reviewers: None
Maniphest Tasks: T13546: Modernize the "arc land" workflow
Commits: rARC8795282286a7: (stable) Promote 2020 Week 26
rARCa5480609f870: Render the state tree in "arc branches" slightly more cleanly

Summary

Ref T13546. Try using unicode box drawing characters to render a more obvious tree struture in "arc branches".

Unclear if this has enough support to use, but seems okay so far.

Test Plan

Ran "arc branches", saw a nicer tree display.

Diff Detail

Repository

rARC Arcanist

Branch

treeview1

Lint

Lint OK

Unit

Unit Tests OK

Build Status

Buildable 24732
Build 34107: Run Core Tests
Build 34106: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 3 2020, 6:39 PM

Harbormaster completed remote builds in B24732: Diff 50914.Jul 3 2020, 6:40 PM

epriestley requested review of this revision.Jul 3 2020, 6:40 PM

Improve "stack" behavior.

Harbormaster completed remote builds in B24733: Diff 50915.Jul 3 2020, 6:55 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 3 2020, 7:43 PM

Closed by commit rARCa5480609f870: Render the state tree in "arc branches" slightly more cleanly (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCa5480609f870: Render the state tree in "arc branches" slightly more cleanly.

epriestley added a commit: rARC8795282286a7: (stable) Promote 2020 Week 26.Jul 3 2020, 8:10 PM

Revision Contents
Changeset List

Path

Size

src/

repository/

graph/

view/

ArcanistCommitGraphSetView.php

83 lines

Diff 50914

View Options

src/repository/graph/view/ArcanistCommitGraphSetView.php

Render the state tree in "arc branches" slightly more cleanlyClosedPublicActions