Page MenuHomePhabricator

On Windows, don't try to set "stdin" nonblocking, as it does not work
ClosedPublic

Authored by epriestley on Jun 12 2020, 9:18 PM.

Details

Summary

See https://discourse.phabricator-community.org/t/arc-land-fail-unable-to-set-stdin-nonblocking/4006/.

See also https://bugs.php.net/bug.php?id=34972.

Note that you can't ^C during a prompt (or at any other time) in Windows currently, see T13549.

Test Plan

On Windows, hit a prompt in "arc land", then answered it successfully.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jun 12 2020, 9:18 PM
epriestley requested review of this revision.Jun 12 2020, 9:18 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 12 2020, 9:29 PM
This revision was automatically updated to reflect the committed changes.