On Windows, don't try to set "stdin" nonblocking, as it does not work
ClosedPublic
Actions

Authored by epriestley on Jun 12 2020, 9:18 PM.

Tags

None

Referenced Files

	F15492606: D21358.id50840.diff
	Sat, Apr 12, 4:25 PM

	F15483459: D21358.id.diff
	Wed, Apr 9, 12:26 PM

	F15468758: D21358.id50839.diff
	Fri, Apr 4, 5:16 AM

	F15460117: D21358.id50839.diff
	Mon, Mar 31, 8:14 PM

	F15455177: D21358.id.diff
	Sat, Mar 29, 10:38 PM

	F15451612: D21358.diff
	Fri, Mar 28, 10:59 PM

	F15428442: D21358.id50840.diff
	Sun, Mar 23, 8:22 PM

	F15384755: D21358.id50840.diff
	Mar 14 2025, 8:43 PM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rARC33dfa859d8e6: On Windows, don't try to set "stdin" nonblocking, as it does not work

Summary

See https://discourse.phabricator-community.org/t/arc-land-fail-unable-to-set-stdin-nonblocking/4006/.

Note that you can't ^C during a prompt (or at any other time) in Windows currently, see T13549.

Test Plan

On Windows, hit a prompt in "arc land", then answered it successfully.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 12 2020, 9:18 PM

Harbormaster completed remote builds in B24659: Diff 50839.Jun 12 2020, 9:18 PM

epriestley requested review of this revision.Jun 12 2020, 9:18 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 12 2020, 9:29 PM

Closed by commit rARC33dfa859d8e6: On Windows, don't try to set "stdin" nonblocking, as it does not work (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC33dfa859d8e6: On Windows, don't try to set "stdin" nonblocking, as it does not work.

Revision Contents
Changeset List

Path

Size

src/

toolset/

ArcanistPrompt.php

80 lines

Diff 50840

View Options

src/toolset/ArcanistPrompt.php

On Windows, don't try to set "stdin" nonblocking, as it does not workClosedPublicActions