On Windows, don't try to set "stdin" nonblocking, as it does not work
ClosedPublic
Actions

Authored by epriestley on Jun 12 2020, 9:18 PM.

Tags

None

Referenced Files

	F15335124: D21358.diff
	Sat, Mar 8, 2:24 PM

	F15297772: D21358.id.diff
	Wed, Mar 5, 12:35 PM

	Unknown Object (File)
	Mon, Mar 3, 3:54 PM

	Unknown Object (File)
	Thu, Feb 20, 4:51 PM

	Unknown Object (File)
	Mon, Feb 17, 11:29 PM

	Unknown Object (File)
	Thu, Feb 13, 12:33 AM

	Unknown Object (File)
	Wed, Feb 12, 10:48 PM

	Unknown Object (File)
	Tue, Feb 11, 10:21 PM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rARC33dfa859d8e6: On Windows, don't try to set "stdin" nonblocking, as it does not work

Summary

See https://discourse.phabricator-community.org/t/arc-land-fail-unable-to-set-stdin-nonblocking/4006/.

Note that you can't ^C during a prompt (or at any other time) in Windows currently, see T13549.

Test Plan

On Windows, hit a prompt in "arc land", then answered it successfully.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 12 2020, 9:18 PM

Harbormaster completed remote builds in B24659: Diff 50839.Jun 12 2020, 9:18 PM

epriestley requested review of this revision.Jun 12 2020, 9:18 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 12 2020, 9:29 PM

Closed by commit rARC33dfa859d8e6: On Windows, don't try to set "stdin" nonblocking, as it does not work (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC33dfa859d8e6: On Windows, don't try to set "stdin" nonblocking, as it does not work.

Revision Contents
Changeset List

Path

Size

src/

toolset/

ArcanistPrompt.php

80 lines

Diff 50840

View Options

src/toolset/ArcanistPrompt.php

On Windows, don't try to set "stdin" nonblocking, as it does not workClosedPublicActions