Page MenuHomePhabricator

When a linter raises a message at a nonexistent line, don't fatal during rendering
ClosedPublic

Authored by epriestley on Jun 12 2020, 7:11 PM.

Details

Summary

See PHI1782. If a linter raises a message at a line which does not exist in the file, render a confused warning rather than fataling.

This is a long-existing issue which was exacerbated by D21044.

Test Plan

Modified a linter to raise issues at line 99999. Before change: fatal in console rendering. After change: reasonable rendering.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jun 12 2020, 7:11 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 12 2020, 7:12 PM
Harbormaster failed remote builds in B24655: Diff 50835!
epriestley updated this revision to Diff 50836.Jun 12 2020, 7:28 PM
  • Allow a linter to raise messages just past the very end of a file.
epriestley requested review of this revision.Jun 12 2020, 7:28 PM