Mark the wildcard argument to "arc liberate" as a path argument for shell completion
ClosedPublic
Actions

Authored by epriestley on May 28 2020, 2:25 PM.

Tags

None

Referenced Files

	F18783773: D21292.id.diff
	Mon, Oct 13, 9:27 AM

	F18734306: D21292.id.diff
	Tue, Sep 30, 10:51 PM

	F18706134: D21292.diff
	Sun, Sep 28, 3:29 PM

	F18706103: D21292.diff
	Sun, Sep 28, 3:22 PM

	F18706100: D21292.diff
	Sun, Sep 28, 3:22 PM

	F18652985: D21292.diff
	Sep 21 2025, 10:27 AM

	F18634973: D21292.diff
	Sep 16 2025, 11:56 PM

	F18101124: D21292.diff
	Aug 9 2025, 12:20 PM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rARCc76cfc8c82c0: Mark the wildcard argument to "arc liberate" as a path argument for shell…

Summary

This is a path argument, and shell completion should suggest tabs.

Test Plan

Typed "arc liberate s<tab>", got path suggestions.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 28 2020, 2:25 PM

Harbormaster completed remote builds in B24524: Diff 50704.May 28 2020, 2:25 PM

epriestley requested review of this revision.May 28 2020, 2:25 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 28 2020, 2:33 PM

Closed by commit rARCc76cfc8c82c0: Mark the wildcard argument to "arc liberate" as a path argument for shell… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCc76cfc8c82c0: Mark the wildcard argument to "arc liberate" as a path argument for shell….

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistLiberateWorkflow.php

3 lines

Diff 50706

View Options

src/workflow/ArcanistLiberateWorkflow.php

Mark the wildcard argument to "arc liberate" as a path argument for shell completionClosedPublicActions