Make server components of inline comment content handling state-oriented
ClosedPublic
Actions

Authored by epriestley on May 19 2020, 9:56 PM.

Details

Reviewers: None
Maniphest Tasks: T13513: Make schema changes to inlines to prepare for new inline features
Commits: rP00430fdbe117: Make server components of inline comment content handling state-oriented

Summary

Ref T13513. Introduce a formal server-side content state object so the whole state can be saved and restored to the drafts table, read from the request, etc.

Test Plan

Created and edited inlines. Reloaded drafts with edits. Submitted normal and editing comments. Grepped for affected symbols.

Diff Detail

Repository

rP Phabricator

Branch

inline9

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24479
Build 33732: Run Core Tests
Build 33731: arc lint + arc unit

Event Timeline

epriestley created this revision.May 19 2020, 9:56 PM

Harbormaster completed remote builds in B24479: Diff 50660.May 19 2020, 9:57 PM

epriestley requested review of this revision.May 19 2020, 9:57 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2020, 9:26 PM

Closed by commit rP00430fdbe117: Make server components of inline comment content handling state-oriented (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP00430fdbe117: Make server components of inline comment content handling state-oriented.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

src/

__phutil_library_map__.php

infrastructure/

diff/

PhabricatorInlineCommentController.php

26 lines

inline/

PhabricatorDiffInlineCommentContentState.php

69 lines

PhabricatorInlineCommentContentState.php

47 lines

interface/

PhabricatorInlineComment.php

57 lines

query/

PhabricatorDiffInlineCommentQuery.php

6 lines

view/

PHUIDiffInlineCommentDetailView.php

1 line

PHUIDiffInlineCommentEditView.php

7 lines

webroot/

rsrc/

js/

application/

diff/

DiffInline.js

48 lines

Diff 50660

View Options

resources/celerity/map.php

View Options

src/__phutil_library_map__.php

View Options

src/infrastructure/diff/PhabricatorInlineCommentController.php

View Options

src/infrastructure/diff/inline/PhabricatorDiffInlineCommentContentState.php

View Options

src/infrastructure/diff/inline/PhabricatorInlineCommentContentState.php

View Options

src/infrastructure/diff/interface/PhabricatorInlineComment.php

View Options

src/infrastructure/diff/query/PhabricatorDiffInlineCommentQuery.php

View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentEditView.php

View Options

webroot/rsrc/js/application/diff/DiffInline.js

Make server components of inline comment content handling state-orientedClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50660

resources/celerity/map.php

src/__phutil_library_map__.php

src/infrastructure/diff/PhabricatorInlineCommentController.php

src/infrastructure/diff/inline/PhabricatorDiffInlineCommentContentState.php

src/infrastructure/diff/inline/PhabricatorInlineCommentContentState.php

src/infrastructure/diff/interface/PhabricatorInlineComment.php

src/infrastructure/diff/query/PhabricatorDiffInlineCommentQuery.php

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

src/infrastructure/diff/view/PHUIDiffInlineCommentEditView.php

webroot/rsrc/js/application/diff/DiffInline.js

Make server components of inline comment content handling state-oriented
ClosedPublic
Actions

Revision Contents
Changeset List