Page MenuHomePhabricator

Update MySQL schema inspection code for deprecation of integer display widths
ClosedPublic

Authored by epriestley on May 18 2020, 7:09 PM.
Tags
None
Referenced Files
F13089463: D21265.diff
Thu, Apr 25, 1:49 AM
F13086128: D21265.diff
Thu, Apr 25, 12:04 AM
Unknown Object (File)
Tue, Apr 23, 6:51 PM
Unknown Object (File)
Sat, Apr 20, 5:15 PM
Unknown Object (File)
Wed, Apr 17, 10:01 PM
Unknown Object (File)
Mar 5 2024, 12:46 PM
Unknown Object (File)
Feb 15 2024, 2:04 PM
Unknown Object (File)
Jan 5 2024, 3:33 AM
Subscribers
None

Details

Summary

Fixes T13536. See that task for discussion.

Older versions of MySQL (roughly, prior to 8.0.19) emit "int(10)" types. Newer versions emit "int" types. Accept these as equivalent.

Test Plan

Ran bin/storage upgrade --force against MySQL 8.0.11 and 8.0.20. Got clean adjustment lists on both versions.

Diff Detail

Repository
rP Phabricator
Branch
schema1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24455
Build 33698: Run Core Tests
Build 33697: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 18 2020, 7:10 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.