See https://github.com/phacility/phabricator/pull/854. In some situations, line-break: anywhere produces better behavior than word-break: break-all. It never appears to produce worse behavior.
Details
Details
- Break behavior changes if a line contains "<span />" elements caused by syntax highlighting. This CSS adjustment only appears to apply to text with internal "<span />" elements.
- This specifically impacts certain internal breakpoints adjacent to punctuation, so the test case is highly specific. Generic test cases with latin word characters do not evidence any behavioral changes.
- This change appears to have no impact on Safari, which uses the better behavior in all cases.
- Before Patch: In Firefox and Chrome, this specific change breaks awkwardly. There is more room for text to fit on the broken line:
Firefox
Chrome
- After Patch: Firefox and Chrome break the line better. Here's Firefox:
- Additional context:
Safari Behavior (Unchanged)
Chrome with no highlighting (desirable behavior). Firefox does the same thing.
Also tested other cases, which seem never-worse in any browser.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- break-behavior
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 24413 Build 33638: Run Core Tests Build 33637: arc lint + arc unit