Page MenuHomePhabricator

Lift inline comment draft behaviors to "InlineController"
ClosedPublic

Authored by epriestley on May 8 2020, 1:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 5 2025, 4:54 PM
Unknown Object (File)
Jun 3 2025, 9:29 AM
Unknown Object (File)
Jun 2 2025, 8:57 AM
Unknown Object (File)
Jun 1 2025, 6:51 PM
Unknown Object (File)
May 31 2025, 7:38 AM
Unknown Object (File)
May 1 2025, 11:44 PM
Unknown Object (File)
Apr 29 2025, 7:11 PM
Unknown Object (File)
Apr 28 2025, 8:01 AM
Subscribers
None

Details

Summary

Ref T13513. Currently, if you:

  • click a line to create an inline;
  • type some text;
  • wait a moment; and
  • close the page.

...you don't get an "Unsubmitted Draft" marker in the revision list.

Lift all the draft behavior to "InlineController" and make saving a draft dirty the overall container draft state.

Test Plan
  • Took the steps described above, got a draft state marker.
  • Created, edited, submitted, etc., inlines in Diffusion and Differential.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 8 2020, 1:52 PM
This revision was automatically updated to reflect the committed changes.