Page MenuHomePhabricator

Lift inline comment draft behaviors to "InlineController"
ClosedPublic

Authored by epriestley on May 8 2020, 1:26 PM.
Tags
None
Referenced Files
F14755822: D21235.id50571.diff
Tue, Jan 21, 5:11 PM
Unknown Object (File)
Tue, Jan 21, 9:32 AM
Unknown Object (File)
Mon, Jan 6, 9:50 PM
Unknown Object (File)
Mon, Dec 30, 12:34 PM
Unknown Object (File)
Fri, Dec 27, 1:22 AM
Unknown Object (File)
Dec 21 2024, 4:26 PM
Unknown Object (File)
Dec 17 2024, 7:42 AM
Unknown Object (File)
Dec 16 2024, 1:47 PM
Subscribers
None

Details

Summary

Ref T13513. Currently, if you:

  • click a line to create an inline;
  • type some text;
  • wait a moment; and
  • close the page.

...you don't get an "Unsubmitted Draft" marker in the revision list.

Lift all the draft behavior to "InlineController" and make saving a draft dirty the overall container draft state.

Test Plan
  • Took the steps described above, got a draft state marker.
  • Created, edited, submitted, etc., inlines in Diffusion and Differential.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 8 2020, 1:52 PM
This revision was automatically updated to reflect the committed changes.