Page MenuHomePhabricator

Lift inline comment draft behaviors to "InlineController"
ClosedPublic

Authored by epriestley on May 8 2020, 1:26 PM.
Tags
None
Referenced Files
F15468744: D21235.id50573.diff
Fri, Apr 4, 5:00 AM
F15464122: D21235.diff
Wed, Apr 2, 6:35 AM
F15463273: D21235.diff
Tue, Apr 1, 9:55 PM
F15459178: D21235.id50571.diff
Mon, Mar 31, 10:36 AM
F15456357: D21235.id50573.diff
Sun, Mar 30, 9:03 AM
F15454870: D21235.id.diff
Sat, Mar 29, 8:56 PM
F15449279: D21235.diff
Fri, Mar 28, 9:15 AM
F15430617: D21235.id50573.diff
Mon, Mar 24, 8:28 AM
Subscribers
None

Details

Summary

Ref T13513. Currently, if you:

  • click a line to create an inline;
  • type some text;
  • wait a moment; and
  • close the page.

...you don't get an "Unsubmitted Draft" marker in the revision list.

Lift all the draft behavior to "InlineController" and make saving a draft dirty the overall container draft state.

Test Plan
  • Took the steps described above, got a draft state marker.
  • Created, edited, submitted, etc., inlines in Diffusion and Differential.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 8 2020, 1:52 PM
This revision was automatically updated to reflect the committed changes.