Page MenuHomePhabricator

Lift inline comment draft behaviors to "InlineController"
ClosedPublic

Authored by epriestley on May 8 2020, 1:26 PM.
Tags
None
Referenced Files
F19156856: D21235.diff
Dec 12 2025, 10:13 PM
F19115651: D21235.diff
Dec 9 2025, 7:08 PM
F19098903: D21235.id.diff
Dec 4 2025, 6:36 PM
F19089488: D21235.diff
Dec 3 2025, 7:27 AM
F19060805: D21235.diff
Nov 29 2025, 10:20 AM
F18866714: D21235.id.diff
Nov 3 2025, 6:52 PM
F18806636: D21235.id50573.diff
Oct 18 2025, 8:47 PM
F18670350: D21235.diff
Sep 24 2025, 11:57 PM
Subscribers
None

Details

Summary

Ref T13513. Currently, if you:

  • click a line to create an inline;
  • type some text;
  • wait a moment; and
  • close the page.

...you don't get an "Unsubmitted Draft" marker in the revision list.

Lift all the draft behavior to "InlineController" and make saving a draft dirty the overall container draft state.

Test Plan
  • Took the steps described above, got a draft state marker.
  • Created, edited, submitted, etc., inlines in Diffusion and Differential.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 8 2020, 1:52 PM
This revision was automatically updated to reflect the committed changes.