Page MenuHomePhabricator

Lift inline comment draft behaviors to "InlineController"
ClosedPublic

Authored by epriestley on May 8 2020, 1:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 20, 1:36 AM
Unknown Object (File)
Mon, Feb 17, 12:01 AM
Unknown Object (File)
Thu, Feb 13, 8:56 PM
Unknown Object (File)
Sun, Feb 9, 9:15 AM
Unknown Object (File)
Sun, Feb 9, 9:15 AM
Unknown Object (File)
Sun, Feb 9, 9:15 AM
Unknown Object (File)
Sun, Feb 9, 9:15 AM
Unknown Object (File)
Sun, Feb 9, 1:15 AM
Subscribers
None

Details

Summary

Ref T13513. Currently, if you:

  • click a line to create an inline;
  • type some text;
  • wait a moment; and
  • close the page.

...you don't get an "Unsubmitted Draft" marker in the revision list.

Lift all the draft behavior to "InlineController" and make saving a draft dirty the overall container draft state.

Test Plan
  • Took the steps described above, got a draft state marker.
  • Created, edited, submitted, etc., inlines in Diffusion and Differential.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 8 2020, 1:52 PM
This revision was automatically updated to reflect the committed changes.