Page MenuHomePhabricator

Lift inline comment draft behaviors to "InlineController"
ClosedPublic

Authored by epriestley on May 8 2020, 1:26 PM.
Tags
None
Referenced Files
F18670350: D21235.diff
Wed, Sep 24, 11:57 PM
F18112327: D21235.diff
Aug 12 2025, 4:24 PM
F18101102: D21235.id.diff
Aug 9 2025, 12:19 PM
F18096420: D21235.id50573.diff
Aug 8 2025, 6:52 AM
F17948565: D21235.id.diff
Jul 31 2025, 9:26 PM
F17923251: D21235.diff
Jul 30 2025, 7:58 AM
F17702836: D21235.id50573.diff
Jul 15 2025, 11:52 PM
Unknown Object (File)
Jun 5 2025, 4:54 PM
Subscribers
None

Details

Summary

Ref T13513. Currently, if you:

  • click a line to create an inline;
  • type some text;
  • wait a moment; and
  • close the page.

...you don't get an "Unsubmitted Draft" marker in the revision list.

Lift all the draft behavior to "InlineController" and make saving a draft dirty the overall container draft state.

Test Plan
  • Took the steps described above, got a draft state marker.
  • Created, edited, submitted, etc., inlines in Diffusion and Differential.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 8 2020, 1:52 PM
This revision was automatically updated to reflect the committed changes.