Page MenuHomePhabricator

When loading a page with inlines, don't select/focus inlines which we immediately upgrade to "editing"
ClosedPublic

Authored by epriestley on Mon, May 4, 8:37 PM.

Details

Summary

Ref T13513. This is a bit clumsy, but the cleanest way to implement "isEditing" inlines today is to send them down as normal inlines and then simulate clicking "edit" on them.

When we do, don't focus the resulting editor: focusing it makes the page scroll around and highlight things in essentially random order as the editors load in.

Test Plan

Reloaded a page with some open editors, wasn't scrolled to them.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mon, May 4, 8:37 PM
epriestley requested review of this revision.Mon, May 4, 8:38 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mon, May 4, 10:15 PM
This revision was automatically updated to reflect the committed changes.