Make content more prominent in Files and move some details to the curtain
ClosedPublic
Actions

Authored by epriestley on May 1 2020, 2:39 PM.

Details

Reviewers: None
Maniphest Tasks: T13528: When a Paste can be rendered by DocumentEngine, provide a hint that the rendering is available
Commits: rPfbbd2e35cb46: Make content more prominent in Files and move some details to the curtain

Summary

Ref T13528. Now that we're hinting users into Files, put the content first and move the detail panel under it. Move the most-useful details (author, size, dimensions) into the curtain.

Test Plan

Screen Shot 2020-05-01 at 7.38.55 AM.png (922×1 px, 299 KB)

Diff Detail

Repository

rP Phabricator

Branch

paste4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24300
Build 33477: Run Core Tests
Build 33476: arc lint + arc unit

Event Timeline

epriestley created this revision.May 1 2020, 2:39 PM

Harbormaster completed remote builds in B24300: Diff 50485.May 1 2020, 2:40 PM

epriestley requested review of this revision.May 1 2020, 2:40 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 1 2020, 4:11 PM

Closed by commit rPfbbd2e35cb46: Make content more prominent in Files and move some details to the curtain (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPfbbd2e35cb46: Make content more prominent in Files and move some details to the curtain.

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

controller/

PhabricatorFileViewController.php

99 lines

Diff 50485

View Options

src/applications/files/controller/PhabricatorFileViewController.php

Make content more prominent in Files and move some details to the curtainClosedPublicActions