Page MenuHomePhabricator
Differential D21196

When a Paste has a useful alternative rendering in Files, provide a hint
ClosedPublic
Actions

Authored by epriestley on May 1 2020, 1:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 3:09 PM
Unknown Object (File)
Tue, Apr 9, 12:56 PM
Unknown Object (File)
Tue, Mar 26, 9:23 PM
Unknown Object (File)
Feb 8 2024, 4:19 PM
Unknown Object (File)
Dec 26 2023, 11:05 AM
Unknown Object (File)
Dec 24 2023, 9:03 PM
Unknown Object (File)
Dec 23 2023, 11:58 AM
Unknown Object (File)
Dec 19 2023, 12:55 PM
View All 89 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13528: When a Paste can be rendered by DocumentEngine, provide a hint that the rendering is available
Commits
rP3c1f393c812f: When a Paste has a useful alternative rendering in Files, provide a hint
Summary

Ref T13528. When a file in Paste (like a Jupyter notebook) has a good/useful document engine, provide a link to Files.

Test Plan

Screen Shot 2020-05-01 at 6.49.46 AM.png (226×1 px, 31 KB)

Diff Detail

Repository
rP Phabricator
Branch
paste1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24295
Build 33467: Run Core Tests
Build 33466: arc lint + arc unit

Event Timeline

epriestley created this revision.May 1 2020, 1:53 PM
Harbormaster completed remote builds in B24295: Diff 50480.May 1 2020, 1:54 PM
epriestley requested review of this revision.May 1 2020, 1:54 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 1 2020, 4:09 PM
Closed by commit rP3c1f393c812f: When a Paste has a useful alternative rendering in Files, provide a hint (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP3c1f393c812f: When a Paste has a useful alternative rendering in Files, provide a hint.

Revision Contents
Changeset List

PathSize
src/
applications/
console/
core/
2 lines
files/
document/
4 lines
4 lines
render/
6 lines
paste/
controller/
63 lines

Diff 50480

View Options

src/applications/console/core/DarkConsoleCore.php

Loading...
View Options

src/applications/files/document/PhabricatorDocumentEngine.php

Loading...
View Options

src/applications/files/document/PhabricatorJupyterDocumentEngine.php

Loading...
View Options

src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php

Loading...
View Options

src/applications/paste/controller/PhabricatorPasteViewController.php

Loading...
Phabricator · Built by Phacility