Page MenuHomePhabricator

When users submit "editing" inlines, warn them that their inlines will be saved
ClosedPublic

Authored by epriestley on Apr 30 2020, 12:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 15, 8:40 PM
Unknown Object (File)
Jan 21 2024, 5:29 AM
Unknown Object (File)
Dec 27 2023, 1:23 PM
Unknown Object (File)
Dec 23 2023, 1:14 AM
Unknown Object (File)
Dec 22 2023, 2:56 AM
Unknown Object (File)
Dec 19 2023, 3:05 PM
Unknown Object (File)
Dec 19 2023, 3:25 AM
Unknown Object (File)
Dec 14 2023, 9:27 AM
Subscribers
None

Details

Summary

Ref T13513. This slightly expands the existing-but-hacky "warning" workflow to cover both "mentions on draft" and "submitting inlines being edited".

Test Plan
  • Submitted changes to a revision with mentions on a draft, inlines being edited, both, and neither.
  • Got sensible warnings in the cases where warnings were appropriate.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 8:13 PM
This revision was automatically updated to reflect the committed changes.