Fix an issue where the Maniphest burnup chart was trying to render a non-View object
ClosedPublic
Actions

Authored by epriestley on Apr 29 2020, 11:57 AM.

Details

Reviewers: None
Commits: rPce66b1c6287f: (stable) Fix an issue where the Maniphest burnup chart was trying to render a…
rPb648a8584111: Fix an issue where the Maniphest burnup chart was trying to render a non-View…

Summary

See PHI1714. This code is incorrectly rendering the chart panel twice, sort of, and passing a non-View object to rendering.

After D21044, this fatals by raising an exception in rendering.

Test Plan

Loaded page, no more exception.

Diff Detail

Repository

rP Phabricator

Branch

burnup1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24267
Build 33425: Run Core Tests
Build 33424: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 29 2020, 11:57 AM

Harbormaster completed remote builds in B24267: Diff 50448.Apr 29 2020, 11:58 AM

epriestley requested review of this revision.Apr 29 2020, 11:58 AM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 29 2020, 12:06 PM

Closed by commit rPb648a8584111: Fix an issue where the Maniphest burnup chart was trying to render a non-View… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPb648a8584111: Fix an issue where the Maniphest burnup chart was trying to render a non-View….

epriestley added a commit: rPce66b1c6287f: (stable) Fix an issue where the Maniphest burnup chart was trying to render a….Apr 29 2020, 12:09 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

controller/

ManiphestReportController.php

6 lines

Diff 50448

View Options

src/applications/maniphest/controller/ManiphestReportController.php

Fix an issue where the Maniphest burnup chart was trying to render a non-View objectClosedPublicActions