Page MenuHomePhabricator

Make omitting "value" from a transaction description an explicit error
ClosedPublic

Authored by epriestley on Apr 27 2020, 8:14 PM.
Tags
None
Referenced Files
F15383424: D21176.diff
Fri, Mar 14, 4:40 PM
F15316002: D21176.diff
Thu, Mar 6, 6:18 PM
Unknown Object (File)
Thu, Feb 20, 11:35 AM
Unknown Object (File)
Feb 14 2025, 6:10 PM
Unknown Object (File)
Feb 9 2025, 9:07 AM
Unknown Object (File)
Feb 9 2025, 9:07 AM
Unknown Object (File)
Feb 9 2025, 9:07 AM
Unknown Object (File)
Feb 9 2025, 9:07 AM
Subscribers
None

Details

Summary

See PHI1710. Until D21044, some transactions could omit "value" and apply correctly. This now throws an exception when accessing $xaction['value']. All transactions are expected to have a "value" key, so require it explicitly rather than implicitly.

Test Plan

Submitted a transaction with a "type" but no "value". After D21044, got a language-level exception. After this change, got an explicit exception.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable