Paths

Table of Contentst

Differential D21176

Make omitting "value" from a transaction description an explicit error
ClosedPublic
Actions

Authored by epriestley on Apr 27 2020, 8:14 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 25, 2:33 AM

	Unknown Object (File)
	Wed, Nov 20, 5:28 PM

	Unknown Object (File)
	Mon, Nov 18, 5:11 PM

	Unknown Object (File)
	Thu, Nov 14, 6:56 AM

	Unknown Object (File)
	Thu, Nov 14, 4:04 AM

	Unknown Object (File)
	Sun, Nov 10, 8:07 AM

	Unknown Object (File)
	Thu, Oct 31, 6:29 AM

	Unknown Object (File)
	Wed, Oct 30, 6:46 AM

Subscribers

None

Details

Reviewers: None
Commits: rPc176a3038a4b: (stable) Make omitting "value" from a transaction description an explicit error
rPb5bed7b0fa87: Make omitting "value" from a transaction description an explicit error

Summary

See PHI1710. Until D21044, some transactions could omit "value" and apply correctly. This now throws an exception when accessing $xaction['value']. All transactions are expected to have a "value" key, so require it explicitly rather than implicitly.

Test Plan

Submitted a transaction with a "type" but no "value". After D21044, got a language-level exception. After this change, got an explicit exception.

Diff Detail

Repository

Branch

edit1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24245
Build 33394: Run Core Tests
Build 33393: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 27 2020, 8:14 PM

Harbormaster completed remote builds in B24245: Diff 50426.Apr 27 2020, 8:15 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 27 2020, 8:15 PM

epriestley requested review of this revision.

Closed by commit rPb5bed7b0fa87: Make omitting "value" from a transaction description an explicit error (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPb5bed7b0fa87: Make omitting "value" from a transaction description an explicit error.

epriestley added a commit: rPc176a3038a4b: (stable) Make omitting "value" from a transaction description an explicit error.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editengine/

PhabricatorEditEngine.php

10 lines

Diff 50426

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...