Page MenuHomePhabricator
Differential D21168

Make "arc <workflow> --help" work again for workflows which haven't updated yet
ClosedPublic
Actions

Authored by epriestley on Apr 25 2020, 3:54 PM.
Tags
None
Referenced Files
F15490070: D21168.diff
Fri, Apr 11, 2:04 PM
F15490036: D21168.id.diff
Fri, Apr 11, 2:03 PM
F15490008: D21168.id50401.diff
Fri, Apr 11, 2:03 PM
F15490006: D21168.id50402.diff
Fri, Apr 11, 2:03 PM
F15472139: D21168.id50401.diff
Sat, Apr 5, 11:04 AM
F15452853: D21168.id.diff
Sat, Mar 29, 7:45 AM
F15448299: D21168.diff
Fri, Mar 28, 4:02 AM
F15418963: D21168.id50401.diff
Fri, Mar 21, 2:44 AM
View All Files
Subscribers
None

Details

Reviewers
None
Commits
rARCc87880142b72: (stable) Make "arc <workflow> --help" work again for workflows which haven't…
rARCbf76fa547d9f: Make "arc <workflow> --help" work again for workflows which haven't updated yet
Summary

See https://discourse.phabricator-community.org/t/help-is-no-longer-present-for-arc-subcommands-in-todays-stable/3786.

The "--help" flag ends up falling through to the old "arcanist.php", where it becomes lost. Catch it earlier so "arc diff --help" prints diff help, for instance.

Test Plan

Ran arc help diff, arc diff --help, arc --help diff, and similar commands for updated workflows; got help.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
parser/
argument/
33 lines
workflow/
52 lines
runtime/
40 lines
toolset/
5 lines
workflow/
3 lines

Diff 50402

View Options

src/parser/argument/PhutilArgumentParser.php

Loading...
View Options

src/parser/argument/workflow/PhutilHelpArgumentWorkflow.php

Loading...
View Options

src/runtime/ArcanistRuntime.php

Loading...
View Options

src/toolset/ArcanistWorkflowArgument.php

Loading...
View Options

src/toolset/workflow/ArcanistHelpWorkflow.php

Loading...
Phabricator · Built by Phacility