Page MenuHomePhabricator
Differential D21151

Glue the new FormationView on top of the older Filetree view in Differential
ClosedPublic
Actions

Authored by epriestley on Apr 21 2020, 4:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 9:03 AM
Unknown Object (File)
Sun, Feb 9, 9:03 AM
Unknown Object (File)
Sun, Feb 9, 9:02 AM
Unknown Object (File)
Wed, Jan 29, 1:34 PM
Unknown Object (File)
Sat, Jan 25, 7:14 AM
Unknown Object (File)
Sat, Jan 25, 7:14 AM
Unknown Object (File)
Sat, Jan 25, 7:14 AM
Unknown Object (File)
Wed, Jan 22, 2:46 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13516: Remove the "filetree" setting (so it's always enabled for everyone)
Commits
rP646280972b88: Glue the new FormationView on top of the older Filetree view in Differential
Summary

Ref T13516. This glues "FormationView" to "ChangesetList". The actual tree is not functional in any meaningful way yet.

Test Plan

Screen Shot 2020-04-21 at 9.41.58 AM.png (1×1 px, 329 KB)

Diff Detail

Repository
rP Phabricator
Branch
flank2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24178
Build 33300: Run Core Tests
Build 33299: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 21 2020, 4:45 PM
Harbormaster completed remote builds in B24178: Diff 50360.Apr 21 2020, 4:46 PM
epriestley requested review of this revision.Apr 21 2020, 4:46 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 22 2020, 3:29 PM
Closed by commit rP646280972b88: Glue the new FormationView on top of the older Filetree view in Differential (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP646280972b88: Glue the new FormationView on top of the older Filetree view in Differential.

Revision Contents
Changeset List

Diff 50360

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/engine/DifferentialFileTreeEngine.php

Loading...
View Options

src/applications/differential/view/DifferentialChangesetListView.php

Loading...
View Options

src/view/formation/PHUIFormationColumnDynamicView.php

Loading...
View Options

src/view/formation/PHUIFormationColumnItem.php

Loading...
View Options

src/view/formation/PHUIFormationColumnView.php

Loading...
View Options

src/view/formation/PHUIFormationFlankView.php

Loading...
View Options

src/view/formation/PHUIFormationView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-formation-view.css

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...
View Options

webroot/rsrc/js/application/differential/behavior-populate.js

Loading...
View Options

webroot/rsrc/js/phui/behavior-phuix-formation-view.js

Loading...
View Options

webroot/rsrc/js/phuix/PHUIXFormationColumnView.js

Loading...
View Options

webroot/rsrc/js/phuix/PHUIXFormationView.js

Loading...
Phabricator · Built by Phacility