Differential D21148

In Differential, make the "Open in Editor" keystroke work with no selection, or a change or inline selected
ClosedPublic
Actions

Authored by epriestley on Apr 19 2020, 2:20 PM.

Details

Reviewers: None
Maniphest Tasks: T13515: Differential: Inlines and View Options
Commits: rP537ff68edda2: In Differential, make the "Open in Editor" keystroke work with no selection, or…

Summary

Ref T13515. Currently, "Open in Editor" only works with a file-level selection.

If we have a change-level or inline-level selection, open the parent changeset.
If we have no selection, but the banner is showing something, open the fine shown in the banner.

Test Plan

With files, inlines, changes, and no selection, pressed "\". Saw files pop open in my external editor.

Diff Detail

Repository

rP Phabricator

Branch

sticky11

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24164
Build 33283: Run Core Tests
Build 33282: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 19 2020, 2:20 PM

Harbormaster completed remote builds in B24164: Diff 50346.Apr 19 2020, 2:21 PM

epriestley requested review of this revision.Apr 19 2020, 2:21 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 19 2020, 4:41 PM

Closed by commit rP537ff68edda2: In Differential, make the "Open in Editor" keystroke work with no selection, or… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP537ff68edda2: In Differential, make the "Open in Editor" keystroke work with no selection, or….

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

js/

application/

diff/

DiffChangesetList.js

27 lines

Diff 50346

View Options

resources/celerity/map.php