Differential D21132

No-op an ancient Paste edge migration which no longer functions after a database rename
ClosedPublic
Actions

Authored by epriestley on Apr 17 2020, 12:34 PM.

Tags

None

Referenced Files

	F14760444: D21132.diff
	Wed, Jan 22, 6:20 PM

	Unknown Object (File)
	Fri, Jan 3, 2:40 AM

	Unknown Object (File)
	Tue, Dec 31, 6:10 AM

	Unknown Object (File)
	Tue, Dec 31, 6:10 AM

	Unknown Object (File)
	Tue, Dec 31, 6:10 AM

	Unknown Object (File)
	Tue, Dec 24, 3:00 AM

	Unknown Object (File)
	Mon, Dec 23, 6:41 PM

	Unknown Object (File)
	Dec 18 2024, 2:06 PM

Subscribers

Restricted Owners Package

Details

Reviewers: None
Maniphest Tasks: T13510: Migration "20160223.paste.fileedges.php" fails after the "Paste" database was renamed
Commits: rP3e676bce9eda: No-op an ancient Paste edge migration which no longer functions after a…

Summary

Fixes T13510. This migration currently fails because it tries to affect the "paste" database, but when it runs this database will be named "pastebin".

Since the cost of fixing it in place or moving it past the rename migration both seem relatively high (and the cost of throwing it away is plausibly zero) just throw it for now.

Test Plan

Looked at file, saw no more code that can execute.

Diff Detail

Repository

Branch

nopaste

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24142
Build 33244: Run Core Tests
Build 33243: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 17 2020, 12:34 PM

Owners added a subscriber: Restricted Owners Package.Apr 17 2020, 12:34 PM

Harbormaster completed remote builds in B24142: Diff 50324.Apr 17 2020, 12:35 PM

epriestley requested review of this revision.Apr 17 2020, 12:35 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 17 2020, 12:38 PM

Closed by commit rP3e676bce9eda: No-op an ancient Paste edge migration which no longer functions after a… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP3e676bce9eda: No-op an ancient Paste edge migration which no longer functions after a….

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20160223.paste.fileedges.php

20 lines

Diff 50324

resources/sql/autopatches/20160223.paste.fileedges.php

Loading...