Page MenuHomePhabricator
Differential D21120

In Conduit responses, assert that Phabricator supports a "gzip" capability
ClosedPublic
Actions

Authored by epriestley on Apr 14 2020, 11:47 PM.
Tags
None
Referenced Files
F18771143: D21120.id.diff
Wed, Oct 8, 5:56 PM
F18766073: D21120.diff
Tue, Oct 7, 2:49 PM
F18734229: D21120.id.diff
Tue, Sep 30, 10:50 PM
F18659160: D21120.id.diff
Tue, Sep 23, 10:14 AM
F18650727: D21120.id50299.diff
Sep 21 2025, 1:31 AM
F18390338: D21120.id50297.diff
Aug 29 2025, 6:49 AM
F18390062: D21120.id50297.diff
Aug 29 2025, 6:31 AM
F18386906: D21120.id.diff
Aug 29 2025, 2:38 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13507: Compress Conduit client requests
Commits
rP0ea6d131e072: In Conduit responses, assert that Phabricator supports a "gzip" capability
Summary

Ref T13507. If we believe the server can accept "Content-Encoding: gzip" requests, make the claim in an "X-Conduit-Capabilities" header in responses. Clients can use request compression on subsequent requests.

Test Plan

See D21119 for the client piece.

Diff Detail

Repository
rP Phabricator
Branch
gzip3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24115
Build 33204: Run Core Tests
Build 33203: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 14 2020, 11:47 PM
Harbormaster completed remote builds in B24115: Diff 50297.Apr 14 2020, 11:48 PM
epriestley requested review of this revision.Apr 14 2020, 11:48 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 14 2020, 11:51 PM
Closed by commit rP0ea6d131e072: In Conduit responses, assert that Phabricator supports a "gzip" capability (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP0ea6d131e072: In Conduit responses, assert that Phabricator supports a "gzip" capability.

Revision Contents
Changeset List

PathSize
src/
aphront/
requeststream/
3 lines
response/
8 lines
11 lines
applications/
conduit/
controller/
19 lines

Diff 50297

View Options

src/aphront/requeststream/AphrontRequestStream.php

Loading...
View Options

src/aphront/response/AphrontJSONResponse.php

Loading...
View Options

src/aphront/response/AphrontResponse.php

Loading...
View Options

src/applications/conduit/controller/PhabricatorConduitAPIController.php

Loading...
Phabricator · Built by Phacility