Differential D21118

If the Conduit client supports gzip, make calls with "Accept-Encoding: gzip"
ClosedPublic
Actions

Authored by epriestley on Apr 14 2020, 11:21 PM.

Details

Reviewers: None
Maniphest Tasks: T13507: Compress Conduit client requests
Commits: rARCa77da426af20: If the Conduit client supports gzip, make calls with "Accept-Encoding: gzip"

Summary

Ref T13507. Add "Accept-Encoding: gzip" to requests if we can decompress responses.

When we receive a compressed response, decompress it.

Test Plan

Added debugging code, ran some commands, saw smaller payloads over the wire and inline decompression.

Diff Detail

Repository

rARC Arcanist

Branch

compress1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24112
Build 33199: Run Core Tests
Build 33198: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 14 2020, 11:21 PM

Harbormaster completed remote builds in B24112: Diff 50294.Apr 14 2020, 11:22 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 14 2020, 11:22 PM

epriestley requested review of this revision.

Closed by commit rARCa77da426af20: If the Conduit client supports gzip, make calls with "Accept-Encoding: gzip" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCa77da426af20: If the Conduit client supports gzip, make calls with "Accept-Encoding: gzip".

Revision Contents
Changeset List

Path

Size

src/

future/

http/

BaseHTTPFuture.php

20 lines

HTTPSFuture.php

19 lines

Diff 50294

View Options

src/future/http/BaseHTTPFuture.php