Differential D21116

Add a setup warning to detect "SetInputFilter DEFLATE" and other "Content-Encoding" request mangling
ClosedPublic
Actions

Authored by epriestley on Apr 14 2020, 9:25 PM.

Details

Reviewers: None
Maniphest Tasks: T13507: Compress Conduit client requests
Commits: rP6b05d2be287e: Add a setup warning to detect "SetInputFilter DEFLATE" and other "Content…

Summary

Ref T13507. See that task for discussion.

Test Plan

Faked different response behaviors and hit both variations of this error.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 14 2020, 9:25 PM

Harbormaster completed remote builds in B24108: Diff 50290.Apr 14 2020, 9:26 PM

epriestley requested review of this revision.Apr 14 2020, 9:26 PM

epriestley mentioned this in T13507: Compress Conduit client requests.Apr 14 2020, 9:40 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 14 2020, 9:48 PM

Closed by commit rP6b05d2be287e: Add a setup warning to detect "SetInputFilter DEFLATE" and other "Content… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP6b05d2be287e: Add a setup warning to detect "SetInputFilter DEFLATE" and other "Content….

Revision Contents
Changeset List

Path

Size

src/

aphront/

configuration/

AphrontApplicationConfiguration.php

9 lines

requeststream/

AphrontRequestStream.php

20 lines

applications/

config/

check/

PhabricatorWebServerSetupCheck.php

121 lines

Diff 50291

View Options

src/aphront/configuration/AphrontApplicationConfiguration.php

View Options

src/aphront/requeststream/AphrontRequestStream.php

View Options

src/applications/config/check/PhabricatorWebServerSetupCheck.php

Add a setup warning to detect "SetInputFilter DEFLATE" and other "Content-Encoding" request manglingClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50291

src/aphront/configuration/AphrontApplicationConfiguration.php

src/aphront/requeststream/AphrontRequestStream.php

src/applications/config/check/PhabricatorWebServerSetupCheck.php

Add a setup warning to detect "SetInputFilter DEFLATE" and other "Content-Encoding" request mangling
ClosedPublic
Actions

Revision Contents
Changeset List