Only inject legacy Arcanist workflows into "help" if run from the context of an Arcanist runtime
ClosedPublic
Actions

Authored by epriestley on Apr 14 2020, 7:47 PM.

Tags

None

Referenced Files

	F22563123: D21113.id50287.diff
	Thu, Sep 24, 8:06 PM

	Unknown Object (File)
	Jun 21 2026, 9:00 AM

	Unknown Object (File)
	Jun 19 2026, 11:14 PM

	Unknown Object (File)
	Jun 12 2026, 7:16 AM

	Unknown Object (File)
	Apr 18 2026, 9:37 AM

	Unknown Object (File)
	Apr 17 2026, 8:37 PM

	Unknown Object (File)
	Apr 10 2026, 5:43 AM

	Unknown Object (File)
	Mar 8 2026, 7:31 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13490: Upgrade all "classic" Arcanist workflows to Toolsets
Commits: rARC9d0100bda78a: Only inject legacy Arcanist workflows into "help" if run from the context of an…

Summary

Ref T13490. This code is reachable from Phabricator binaries; only inject the legacy stuff if we're in an Arcanist stack.

Test Plan

Ran bin/conduit help from phabricator/.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 14 2020, 7:47 PM

Harbormaster completed remote builds in B24102: Diff 50284.Apr 14 2020, 7:47 PM

epriestley requested review of this revision.Apr 14 2020, 7:47 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 14 2020, 8:24 PM

Closed by commit rARC9d0100bda78a: Only inject legacy Arcanist workflows into "help" if run from the context of an… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC9d0100bda78a: Only inject legacy Arcanist workflows into "help" if run from the context of an….

Revision Contents
Changeset List

Path

Size

src/

parser/

argument/

workflow/

PhutilHelpArgumentWorkflow.php

62 lines

Diff 50287

View Options

src/parser/argument/workflow/PhutilHelpArgumentWorkflow.php

Only inject legacy Arcanist workflows into "help" if run from the context of an Arcanist runtimeClosedPublicActions