Page MenuHomePhabricator
Differential D21100

Remove "backout", "close", "flag", "start", "stop", "time", and "revert" workflows
ClosedPublic
Actions

Authored by epriestley on Apr 13 2020, 1:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 31, 9:07 AM
Unknown Object (File)
Sat, Mar 30, 9:18 AM
Unknown Object (File)
Fri, Mar 29, 5:39 AM
Unknown Object (File)
Mar 14 2024, 6:09 PM
Unknown Object (File)
Mar 10 2024, 8:11 PM
Unknown Object (File)
Feb 24 2024, 5:02 PM
Unknown Object (File)
Feb 4 2024, 12:01 AM
Unknown Object (File)
Jan 10 2024, 6:42 AM
View All 69 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13490: Upgrade all "classic" Arcanist workflows to Toolsets
Commits
rARC196f8f54ce22: Remove "backout", "close", "flag", "start", "stop", "time", and "revert"…
Summary

Ref T13490. These workflows don't seem worth the maintenance cost, see T13488 for discussion.

Test Plan

Grepped for methods which looked like they might only be called by these flows, only dug up the backout stuff.

Diff Detail

Repository
rARC Arcanist
Branch
xflow5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24074
Build 33143: Run Core Tests
Build 33142: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 13 2020, 1:08 PM
Harbormaster completed remote builds in B24074: Diff 50256.Apr 13 2020, 1:08 PM
epriestley requested review of this revision.Apr 13 2020, 1:08 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 13 2020, 2:09 PM
Closed by commit rARC196f8f54ce22: Remove "backout", "close", "flag", "start", "stop", "time", and "revert"… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARC196f8f54ce22: Remove "backout", "close", "flag", "start", "stop", "time", and "revert"….

Revision Contents
Changeset List

Diff 50256

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/repository/api/ArcanistGitAPI.php

Loading...
View Options

src/repository/api/ArcanistMercurialAPI.php

Loading...
View Options

src/workflow/ArcanistBackoutWorkflow.php

Loading...
View Options

src/workflow/ArcanistCloseWorkflow.php

Loading...
View Options

src/workflow/ArcanistFlagWorkflow.php

Loading...
View Options

src/workflow/ArcanistPhrequentWorkflow.php

Loading...
View Options

src/workflow/ArcanistRevertWorkflow.php

Loading...
View Options

src/workflow/ArcanistStartWorkflow.php

Loading...
View Options

src/workflow/ArcanistStopWorkflow.php

Loading...
View Options

src/workflow/ArcanistTimeWorkflow.php

Loading...
Phabricator · Built by Phacility