Page MenuHomePhabricator

Upgrade "arc download" to Toolsets
ClosedPublic

Authored by epriestley on Apr 12 2020, 11:15 PM.
Tags
None
Referenced Files
F18985408: D21097.id50250.diff
Mon, Nov 17, 1:01 PM
F18825172: D21097.id.diff
Thu, Oct 23, 8:03 PM
F18821573: D21097.diff
Thu, Oct 23, 12:31 AM
F18817367: D21097.id50252.diff
Oct 21 2025, 3:02 PM
F18791384: D21097.id50250.diff
Oct 16 2025, 11:19 AM
F18762830: D21097.id.diff
Oct 6 2025, 8:50 PM
F18734217: D21097.id.diff
Sep 30 2025, 10:50 PM
F18721771: D21097.diff
Sep 29 2025, 9:37 PM
Subscribers
None

Details

Summary

Ref T13490. This is mostly straightforward.

  • Drop "--show" in favor of "--as -".
  • Drop support for 4+ year old "file.info" API.
  • Use modern stream-to-disk support so we get a real progress bar and don't need to buffer files into memory.
Test Plan

Downloaded various files, including large files.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 12 2020, 11:18 PM
This revision was automatically updated to reflect the committed changes.