Page MenuHomePhabricator

Upgrade "arc download" to Toolsets
ClosedPublic

Authored by epriestley on Apr 12 2020, 11:15 PM.

Details

Summary

Ref T13490. This is mostly straightforward.

  • Drop "--show" in favor of "--as -".
  • Drop support for 4+ year old "file.info" API.
  • Use modern stream-to-disk support so we get a real progress bar and don't need to buffer files into memory.
Test Plan

Downloaded various files, including large files.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 12 2020, 11:18 PM
This revision was automatically updated to reflect the committed changes.