Differential D21095

Update "arc amend" for Toolsets
ClosedPublic
Actions

Authored by epriestley on Apr 12 2020, 7:34 PM.

Details

Reviewers: None
Maniphest Tasks: T13490: Upgrade all "classic" Arcanist workflows to Toolsets
Commits: rARC0f2e277cd986: Update "arc amend" for Toolsets

Summary

Ref T13490. Moves "arc amend" to Toolsets with modern ref/hardpoint code.

Test Plan

Ran "arc amend --show", "--revision", etc. Hit all the prompts and errors, probably?

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 12 2020, 7:34 PM

Harbormaster completed remote builds in B24056: Diff 50238.Apr 12 2020, 7:35 PM

epriestley requested review of this revision.Apr 12 2020, 7:35 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 12 2020, 8:48 PM

Closed by commit rARC0f2e277cd986: Update "arc amend" for Toolsets (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC0f2e277cd986: Update "arc amend" for Toolsets.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

browse/

query/

ArcanistBrowseCommitHardpointQuery.php

2 lines

ArcanistBrowseURIHardpointQuery.php

2 lines

query/

ArcanistCommitUpstreamHardpointQuery.php

2 lines

ArcanistMessageRevisionHardpointQuery.php

2 lines

ArcanistWorkflowGitHardpointQuery.php

2 lines

ArcanistWorkingCopyCommitHardpointQuery.php

2 lines

ref/

revision/

ArcanistRevisionCommitMessageHardpointQuery.php

2 lines

ArcanistRevisionRef.php

4 lines

ArcanistRevisionSymbolHardpointQuery.php

2 lines

user/

ArcanistUserRef.php

16 lines

ArcanistUserSymbolHardpointQuery.php

2 lines

repository/

api/

ArcanistGitAPI.php

4 lines

ArcanistRepositoryAPI.php

73 lines

runtime/

ArcanistRuntime.php

99 lines

toolset/

query/

	ArcanistRuntimeHardpointQuery.php
	ArcanistWorkflowHardpointQuery.php

23 lines

ArcanistWorkflowHardpointQuery.php

workflow/

ArcanistAmendWorkflow.php

388 lines

ArcanistWorkflow.php

67 lines

xsprintf/

tsprintf.php

17 lines

Diff 50248

View Options

src/__phutil_library_map__.php

View Options

src/browse/query/ArcanistBrowseCommitHardpointQuery.php

View Options

src/browse/query/ArcanistBrowseURIHardpointQuery.php

View Options

src/query/ArcanistCommitUpstreamHardpointQuery.php

View Options

src/query/ArcanistMessageRevisionHardpointQuery.php

View Options

src/query/ArcanistWorkflowGitHardpointQuery.php

View Options

src/query/ArcanistWorkingCopyCommitHardpointQuery.php

View Options

src/ref/revision/ArcanistRevisionCommitMessageHardpointQuery.php

View Options

src/ref/revision/ArcanistRevisionRef.php

View Options

src/ref/revision/ArcanistRevisionSymbolHardpointQuery.php

View Options

src/ref/user/ArcanistUserRef.php

View Options

src/ref/user/ArcanistUserSymbolHardpointQuery.php

View Options

src/repository/api/ArcanistGitAPI.php

View Options

src/repository/api/ArcanistRepositoryAPI.php

View Options

src/runtime/ArcanistRuntime.php

View Options

src/toolset/query/ArcanistRuntimeHardpointQuery.php

View Options

src/toolset/query/ArcanistWorkflowHardpointQuery.php

View Options

src/workflow/ArcanistAmendWorkflow.php

View Options

src/workflow/ArcanistWorkflow.php

View Options

Update "arc amend" for ToolsetsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50248

src/__phutil_library_map__.php

src/browse/query/ArcanistBrowseCommitHardpointQuery.php

src/browse/query/ArcanistBrowseURIHardpointQuery.php

src/query/ArcanistCommitUpstreamHardpointQuery.php

src/query/ArcanistMessageRevisionHardpointQuery.php

src/query/ArcanistWorkflowGitHardpointQuery.php

src/query/ArcanistWorkingCopyCommitHardpointQuery.php

src/ref/revision/ArcanistRevisionCommitMessageHardpointQuery.php

src/ref/revision/ArcanistRevisionRef.php

src/ref/revision/ArcanistRevisionSymbolHardpointQuery.php

src/ref/user/ArcanistUserRef.php

src/ref/user/ArcanistUserSymbolHardpointQuery.php

src/repository/api/ArcanistGitAPI.php

src/repository/api/ArcanistRepositoryAPI.php

src/runtime/ArcanistRuntime.php

src/toolset/query/ArcanistRuntimeHardpointQuery.php

src/toolset/query/ArcanistWorkflowHardpointQuery.php

src/workflow/ArcanistAmendWorkflow.php

src/workflow/ArcanistWorkflow.php

src/xsprintf/tsprintf.php

Update "arc amend" for Toolsets
ClosedPublic
Actions

Revision Contents
Changeset List