Page MenuHomePhabricator

Add ref lookup for username symbols
ClosedPublic

Authored by epriestley on Apr 12 2020, 3:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 17, 7:28 AM
Unknown Object (File)
Feb 16 2024, 6:04 AM
Unknown Object (File)
Feb 3 2024, 11:20 AM
Unknown Object (File)
Jan 20 2024, 8:52 AM
Unknown Object (File)
Jan 9 2024, 5:01 AM
Unknown Object (File)
Jan 9 2024, 5:00 AM
Unknown Object (File)
Dec 31 2023, 8:33 AM
Unknown Object (File)
Dec 27 2023, 1:21 PM
Subscribers
None

Details

Summary

Ref T13490. I'm attempting to update "arc amend", but it needs to fetch revision authors to raise an "amending a revision you don't own" error.

Support user-symbol resolution.

Along the way, this introduces some infrastructure for abstracting away iteration over a multi-page Conduit result set.

Test Plan
  • Ran "arc inspect ..." for various "user(...)" queries.
  • Set page size to 3 and issued a general query, saw the future page it away properly.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 12 2020, 8:42 PM
This revision was automatically updated to reflect the committed changes.