Page MenuHomePhabricator
Differential D21088

Allow "loadHardpoints()" to accept a single ref and/or a single hardpoint
ClosedPublic
Actions

Authored by epriestley on Apr 11 2020, 10:32 PM.
Tags
None
Referenced Files
F14398598: D21088.id50230.diff
Sun, Dec 22, 2:19 PM
Unknown Object (File)
Fri, Dec 20, 7:05 PM
Unknown Object (File)
Fri, Dec 13, 6:37 PM
Unknown Object (File)
Thu, Dec 12, 10:21 PM
Unknown Object (File)
Wed, Dec 11, 9:24 AM
Unknown Object (File)
Thu, Nov 28, 4:43 PM
Unknown Object (File)
Thu, Nov 28, 1:27 PM
Unknown Object (File)
Mon, Nov 25, 11:30 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13490: Upgrade all "classic" Arcanist workflows to Toolsets
Commits
rARC73f48aca7409: Allow "loadHardpoints()" to accept a single ref and/or a single hardpoint
Summary

Ref T13490. There's more array(...) happening in this API than necessary. Sugar it slightly.

Test Plan

Grepped for "loadHardpoints()", ran a couple workflows.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 11 2020, 10:32 PM
Harbormaster completed remote builds in B24048: Diff 50230.Apr 11 2020, 10:32 PM
epriestley requested review of this revision.Apr 11 2020, 10:32 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 12 2020, 8:17 PM
Closed by commit rARC73f48aca7409: Allow "loadHardpoints()" to accept a single ref and/or a single hardpoint (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARC73f48aca7409: Allow "loadHardpoints()" to accept a single ref and/or a single hardpoint.

Revision Contents
Changeset List

Diff 50241

View Options

src/browse/workflow/ArcanistBrowseWorkflow.php

Loading...
View Options

src/workflow/ArcanistDiffWorkflow.php

Loading...
View Options

src/workflow/ArcanistFeatureBaseWorkflow.php

Loading...
View Options

src/workflow/ArcanistInspectWorkflow.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
Phabricator · Built by Phacility