Page MenuHomePhabricator
Differential D21085

Port "arc prompts" from wilds and fix a path issue in shell completion
ClosedPublic
Actions

Authored by epriestley on Apr 11 2020, 5:40 PM.
Tags
None
Referenced Files
F18381341: D21085.id50227.diff
Thu, Aug 28, 7:37 PM
F18375340: D21085.id.diff
Thu, Aug 28, 9:50 AM
F18366838: D21085.id50226.diff
Wed, Aug 27, 10:49 PM
F18364825: D21085.diff
Wed, Aug 27, 7:56 PM
F18364096: D21085.id50226.diff
Wed, Aug 27, 6:14 PM
F18363265: D21085.id50227.diff
Wed, Aug 27, 4:12 PM
F18363251: D21085.id.diff
Wed, Aug 27, 4:11 PM
F18363106: D21085.diff
Wed, Aug 27, 3:44 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13490: Upgrade all "classic" Arcanist workflows to Toolsets
Commits
rARCccd1ebb25686: Port "arc prompts" from wilds and fix a path issue in shell completion
Summary

Ref T13490. Bring "arc prompts" from "wilds" and hook it into the prompt in "arc shell-complete".

See D21069. Fix an issue where the shell hook tested for a path other than the path it writes to.

Test Plan

Ran "arc shell-complete" with no hook and got a prompt. Shell completed things. Ran "arc prompts shell-complete".

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
toolset/
workflow/
80 lines
5 lines
workflow/
60 lines
support/
shell/
hooks/
5 lines

Diff 50227

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/toolset/workflow/ArcanistPromptsWorkflow.php

Loading...
View Options

src/toolset/workflow/ArcanistShellCompleteWorkflow.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
View Options

support/shell/hooks/bash-completion.sh

Loading...
Phabricator · Built by Phacility