Page MenuHomePhabricator
Differential D21080

Bring "pro" browse queries from modern hardpoint code
ClosedPublic
Actions

Authored by epriestley on Apr 10 2020, 2:51 PM.
Tags
None
Referenced Files
F13179133: D21080.diff
Wed, May 8, 8:58 PM
F13176789: D21080.diff
Wed, May 8, 5:18 PM
F13175924: D21080.id50219.diff
Wed, May 8, 8:52 AM
Unknown Object (File)
Sat, May 4, 6:23 PM
Unknown Object (File)
Thu, May 2, 4:02 PM
Unknown Object (File)
Wed, Apr 24, 10:44 PM
Unknown Object (File)
Sun, Apr 21, 1:00 PM
Unknown Object (File)
Sat, Apr 20, 5:11 PM
View All 77 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T11968: Decide the fate of FutureGraph
Commits
rARC9e72e4ed1df5: Bring "pro" browse queries from modern hardpoint code
Summary

Ref T11968. Merge the modern hardpoint queries and refs for the "browse" workflow as "pro" variations.

Test Plan

Ran arc inspect browse(...) for objects, paths, commits, and revisions.

Diff Detail

Repository
rARC Arcanist
Branch
hpx5
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/browse/query/ArcanistBrowseCommitHardpointQuery.php:35XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 24034
Build 33082: Run Core Tests
Build 33081: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 10 2020, 2:51 PM
Harbormaster completed remote builds in B24034: Diff 50216.Apr 10 2020, 2:51 PM
epriestley requested review of this revision.Apr 10 2020, 2:51 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 10 2020, 3:05 PM
Closed by commit rARC9e72e4ed1df5: Bring "pro" browse queries from modern hardpoint code (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARC9e72e4ed1df5: Bring "pro" browse queries from modern hardpoint code.

Revision Contents
Changeset List

Diff 50216

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/browse/query/ArcanistBrowseCommitHardpointQuery.php

Loading...
View Options

src/browse/query/ArcanistBrowseCommitURIHardpointQuery.php

Loading...
View Options

src/browse/query/ArcanistBrowseObjectNameURIHardpointQuery.php

Loading...
View Options

src/browse/query/ArcanistBrowsePathURIHardpointQuery.php

Loading...
View Options

src/browse/query/ArcanistBrowseRevisionURIHardpointQuery.php

Loading...
View Options

src/browse/query/ArcanistBrowseURIHardpointQuery.php

Loading...
View Options

src/browse/ref/ArcanistBrowseRefPro.php

Loading...
View Options

src/browse/ref/ArcanistBrowseURIRefPro.php

Loading...
View Options

src/hardpoint/ArcanistHardpointTask.php

Loading...
View Options

src/inspector/ArcanistBrowseRefInspector.php

Loading...
View Options

src/workflow/ArcanistInspectWorkflow.php

Loading...
Phabricator · Built by Phacility