If daemon running-as-user setup check fails its query, don't bother with it
ClosedPublic
Actions

Authored by epriestley on Apr 3 2020, 11:12 PM.

Details

Reviewers: None
Commits: rP6a62b63db1fe: (stable) If daemon running-as-user setup check fails its query, don't bother…
rP33b73d887ae3: If daemon running-as-user setup check fails its query, don't bother with it

Summary

See https://discourse.phabricator-community.org/t/upgrade-from-sep-30-2016/3702/. A user performing an upgrade from 2016 to 2020 ran into an issue where this setup query is overheating.

This is likely caused by too many rows changing state during query execution, but the particulars aren't important since this setup check isn't too critical and will catch the issue eventually. It's fine to just move on if this query fails for any reason.

Test Plan

Forced the query to overheat, loaded setup issues, got overheating fatal. Applied patch, no more fatal.

Diff Detail

Repository

rP Phabricator

Branch

setup1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23986
Build 33011: Run Core Tests
Build 33010: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 3 2020, 11:12 PM

Harbormaster completed remote builds in B23986: Diff 50167.Apr 3 2020, 11:13 PM

epriestley requested review of this revision.Apr 3 2020, 11:13 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 3 2020, 11:19 PM

Closed by commit rP33b73d887ae3: If daemon running-as-user setup check fails its query, don't bother with it (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP33b73d887ae3: If daemon running-as-user setup check fails its query, don't bother with it.

epriestley added a commit: rP6a62b63db1fe: (stable) If daemon running-as-user setup check fails its query, don't bother….Apr 3 2020, 11:29 PM

JoggerTech added a subscriber: JoggerTech.Apr 4 2020, 12:23 AM

JoggerTech added inline comments.

src/applications/config/check/PhabricatorDaemonsSetupCheck.php
11	add try catch around this line to fix: Exception Query (of class “PhabricatorDaemonLogQuery”) overheated: examined more than 10 raw rows without finding 1 visible object

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

check/

PhabricatorDaemonsSetupCheck.php

15 lines

Diff 50167

View Options

src/applications/config/check/PhabricatorDaemonsSetupCheck.php

If daemon running-as-user setup check fails its query, don't bother with itClosedPublicActions