Differential D20996

Update "arc alias" to modern workflows
ClosedPublic
Actions

Authored by epriestley on Feb 14 2020, 4:47 PM.

Details

Reviewers: None
Maniphest Tasks: T13395: Strip libphutil for parts
Commits: rARC70c6045c7f9f: Update "arc alias" to modern workflows

Summary

Depends on D20993. Ref T13395. Merges the more-modern "alias" out of "experimental".

Test Plan

Defined and invoked aliases. This has some rough edges: notably, no easy list/delete flow.

Diff Detail

Repository

rARC Arcanist

Branch

flow4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23851
Build 32813: Run Core Tests
Build 32812: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 14 2020, 4:47 PM

Harbormaster completed remote builds in B23851: Diff 50025.Feb 14 2020, 4:47 PM

epriestley requested review of this revision.Feb 14 2020, 4:47 PM

epriestley added a child revision: D20997: Port "arc shell-complete" to Toolsets.Feb 14 2020, 5:12 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 14 2020, 5:16 PM

Closed by commit rARC70c6045c7f9f: Update "arc alias" to modern workflows (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC70c6045c7f9f: Update "arc alias" to modern workflows.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

config/

option/

ArcanistAliasesConfigOption.php

13 lines

configuration/

ArcanistConfiguration.php

47 lines

ArcanistConfigurationManager.php

8 lines

runtime/

ArcanistRuntime.php

2 lines

toolset/

ArcanistAlias.php

2 lines

ArcanistAliasEffect.php

1 line

ArcanistAliasEngine.php

29 lines

workflow/

ArcanistAliasWorkflow.php

200 lines

workflow/

ArcanistAliasWorkflow.php

ArcanistWorkflow.php

4 lines

Diff 50025

View Options

src/__phutil_library_map__.php

View Options

src/config/option/ArcanistAliasesConfigOption.php

View Options

src/configuration/ArcanistConfiguration.php

View Options

src/configuration/ArcanistConfigurationManager.php

View Options

src/runtime/ArcanistRuntime.php

View Options

src/toolset/ArcanistAlias.php

View Options

src/toolset/ArcanistAliasEffect.php

View Options

src/toolset/ArcanistAliasEngine.php

View Options

src/toolset/workflow/ArcanistAliasWorkflow.php

View Options

src/workflow/ArcanistAliasWorkflow.php

View Options

src/workflow/ArcanistWorkflow.php

Update "arc alias" to modern workflowsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50025

src/__phutil_library_map__.php

src/config/option/ArcanistAliasesConfigOption.php

src/configuration/ArcanistConfiguration.php

src/configuration/ArcanistConfigurationManager.php

src/runtime/ArcanistRuntime.php

src/toolset/ArcanistAlias.php

src/toolset/ArcanistAliasEffect.php

src/toolset/ArcanistAliasEngine.php

src/toolset/workflow/ArcanistAliasWorkflow.php

src/workflow/ArcanistAliasWorkflow.php

src/workflow/ArcanistWorkflow.php

Update "arc alias" to modern workflows
ClosedPublic
Actions

Revision Contents
Changeset List