Paths

Table of Contentst

Differential D20988

Merge utility/support changes from "wilds" to "master"
ClosedPublic
Actions

Authored by epriestley on Feb 13 2020, 3:59 PM.

Tags

None

Referenced Files

	F14078365: D20988.diff
	Fri, Nov 22, 3:26 AM

	Unknown Object (File)
	Sun, Nov 17, 7:03 PM

	Unknown Object (File)
	Sun, Nov 17, 2:56 PM

	Unknown Object (File)
	Sun, Nov 17, 10:01 AM

	Unknown Object (File)
	Fri, Oct 25, 12:48 AM

	Unknown Object (File)
	Oct 20 2024, 5:37 PM

	Unknown Object (File)
	Oct 17 2024, 3:40 AM

	Unknown Object (File)
	Oct 13 2024, 10:46 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13395: Strip libphutil for parts
Commits: rARCacf060768340: Merge utility/support changes from "wilds" to "master"

Summary

Ref T13395. Merge a lot of stuff which doesn't break existing workflows:

Merge a UTF8 fix for "cmd.exe" on Windows.
Merge minor changes to JSON linters.
Merge some shell completion stuff.
Merge some "arc anoid" fixes.
Merge various Windows improvements to unit tests which interact with processes / the filesystem.
Merge some other Windows path fixes.
Merge a UTF8 character class fix.
Merge script initialization.
Merge unit test support scripts.
Merge some initialization code.
Merge Windows stdout/stderr-as-files code.
Merge a bunch of code for making exec tests work on Windows.
Merge more Windows unit test fixes.
Merge "continue on failure" mode when loading symbols.
Merge "GPC" order CLI fixes.

Test Plan

Ran arc unit --everything; created this change. There's likely some less-than-perfect code here.

Diff Detail

Repository

Branch

wmerge1

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/lint/linter/__tests__/json/25.lint-test:1	TXT2	Tab Literal
Error	src/lint/linter/__tests__/json/26.lint-test:1	TXT2	Tab Literal
Warning	support/unit/sleep.php:	CHMOD1	Invalid Executable
Advice	src/filesystem/Filesystem.php:1127	XHP14	Misuse of `preg_quote`

Unit

Tests Passed

Build Status

Buildable 23835
Build 32786: Run Core Tests
Build 32785: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 13 2020, 3:59 PM

Harbormaster completed remote builds in B23835: Diff 50009.Feb 13 2020, 4:00 PM

epriestley requested review of this revision.Feb 13 2020, 4:00 PM

epriestley added a child revision: D20990: Collapse Arcanist toolsets from "wilds" into "master", as an overlay layer.Feb 13 2020, 9:54 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2020, 10:10 PM

This revision was landed with ongoing or failed builds.

Closed by commit rARCacf060768340: Merge utility/support changes from "wilds" to "master" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCacf060768340: Merge utility/support changes from "wilds" to "master".

Large Diff

This large diff affects 115 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

Path

Size

3 lines

resources/

shell/

bash-completion

scripts/

__init_script__.php

2 lines

18 lines

init/

init-script.php

src/

__phutil_library_map__.php

channel/

__tests__/

PhutilPHPObjectProtocolChannelTestCase.php

3 lines

error/

__tests__/

PhutilOpaqueEnvelopeTestCase.php

27 lines

filesystem/

36 lines

__tests__/

FileFinderTestCase.php

11 lines

FilesystemTestCase.php

6 lines

PhutilFileLockTestCase.php

20 lines

linesofalarge/

__tests__/

LinesOfALargeExecFutureTestCase.php

4 lines

future/

__tests__/

FutureIteratorTestCase.php

6 lines

exec/

152 lines

__tests__/

ExecFutureTestCase.php

35 lines

ExecPassthruTestCase.php

4 lines

oauth/

__tests__/

PhutilOAuth1FutureTestCase.php

4 lines

internationalization/

ArcanistUSEnglishTranslation.php

5 lines

lint/

linter/

__tests__/

ArcanistJSONLintLinterTestCase.php

ArcanistJSONLinterTestCase.php

2 lines

	json/
	jsonlint/

59 lines

3 lines

3 lines

3 lines

3 lines

3 lines

3 lines

3 lines

3 lines

3 lines

2 lines

3 lines

3 lines

3 lines

3 lines

3 lines

3 lines

3 lines

4 lines

4 lines

3 lines

7 lines

3 lines

3 lines

3 lines

3 lines

3 lines

3 lines

3 lines

3 lines

3 lines

3 lines

3 lines

jsonlint/

xhpast/

rules/

__tests__/

ArcanistXHPASTLinterRuleTestCase.php

2 lines

moduleutils/

PhutilLibraryMapBuilder.php

6 lines

parser/

PhutilEditorConfig.php

18 lines

PhutilJSONParser.php

4 lines

phage/

__tests__/

PhageAgentTestCase.php

4 lines

symbols/

PhutilClassMapQuery.php

6 lines

PhutilSymbolLoader.php

58 lines

unit/

engine/

phutil/

PhutilTestCase.php

34 lines

utils/

PhutilExecutionEnvironment.php

30 lines

__tests__/

PhutilUTF8TestCase.php

14 lines

PhutilUtilsTestCase.php

2 lines

28 lines

4 lines

xsprintf/

PhutilTerminalString.php

7 lines

__tests__/

PhutilCsprintfTestCase.php

31 lines

	support/	init/
	scripts/	init/

init-script.php

17 lines

support/

lib/

extract-symbols.php

2 lines

rebuild-map.php

2 lines

shell/

hooks/

bash-completion.sh

9 lines

rules/

templates/

bash-template.sh

22 lines

test/

unit/

4 lines

9 lines

4 lines

20 lines

	unit/
	test/

	lock.php
	lock-file.php

3 lines

xhpast/

build-xhpast.php

2 lines

Diff 50009

.gitignore

resources/shell/bash-completion

scripts/__init_script__.php

scripts/breakout.py

scripts/init/init-script.php

src/__phutil_library_map__.php

src/channel/tests/PhutilPHPObjectProtocolChannelTestCase.php

src/error/tests/PhutilOpaqueEnvelopeTestCase.php

src/filesystem/Filesystem.php

src/filesystem/tests/FileFinderTestCase.php

src/filesystem/tests/FilesystemTestCase.php

src/filesystem/tests/PhutilFileLockTestCase.php

src/filesystem/linesofalarge/tests/LinesOfALargeExecFutureTestCase.php

src/future/tests/FutureIteratorTestCase.php

src/future/exec/ExecFuture.php

src/future/exec/tests/ExecFutureTestCase.php

src/future/exec/tests/ExecPassthruTestCase.php

src/future/oauth/tests/PhutilOAuth1FutureTestCase.php

src/internationalization/ArcanistUSEnglishTranslation.php

src/lint/linter/tests/ArcanistJSONLintLinterTestCase.php

src/lint/linter/tests/ArcanistJSONLinterTestCase.php

src/lint/linter/tests/json/1.lint-test

src/lint/linter/tests/json/10.lint-test

src/lint/linter/tests/json/11.lint-test

src/lint/linter/tests/json/12.lint-test

src/lint/linter/tests/json/13.lint-test

src/lint/linter/tests/json/14.lint-test

src/lint/linter/tests/json/15.lint-test

src/lint/linter/tests/json/16.lint-test

src/lint/linter/tests/json/17.lint-test

src/lint/linter/tests/json/19.lint-test

src/lint/linter/tests/json/2.lint-test

src/lint/linter/tests/json/20.lint-test

src/lint/linter/tests/json/21.lint-test

src/lint/linter/tests/json/22.lint-test

src/lint/linter/tests/json/23.lint-test

src/lint/linter/tests/json/24.lint-test

src/lint/linter/tests/json/25.lint-test

src/lint/linter/tests/json/26.lint-test

src/lint/linter/tests/json/27.lint-test

src/lint/linter/tests/json/28.lint-test

src/lint/linter/tests/json/29.lint-test

src/lint/linter/tests/json/3.lint-test

src/lint/linter/tests/json/30.lint-test

src/lint/linter/tests/json/31.lint-test

src/lint/linter/tests/json/32.lint-test

src/lint/linter/tests/json/33.lint-test

src/lint/linter/tests/json/34.lint-test

src/lint/linter/tests/json/4.lint-test

src/lint/linter/tests/json/5.lint-test

src/lint/linter/tests/json/6.lint-test

src/lint/linter/tests/json/7.lint-test

src/lint/linter/tests/json/8.lint-test

src/lint/linter/tests/json/9.lint-test

src/lint/linter/tests/jsonlint/1.lint-test

src/lint/linter/tests/jsonlint/10.lint-test

src/lint/linter/tests/jsonlint/11.lint-test

src/lint/linter/tests/jsonlint/12.lint-test

src/lint/linter/tests/jsonlint/13.lint-test

src/lint/linter/tests/jsonlint/14.lint-test

src/lint/linter/tests/jsonlint/15.lint-test

src/lint/linter/tests/jsonlint/16.lint-test

src/lint/linter/tests/jsonlint/17.lint-test

src/lint/linter/tests/jsonlint/19.lint-test

src/lint/linter/tests/jsonlint/2.lint-test

src/lint/linter/tests/jsonlint/20.lint-test

src/lint/linter/tests/jsonlint/21.lint-test

src/lint/linter/tests/jsonlint/22.lint-test

src/lint/linter/tests/jsonlint/23.lint-test

src/lint/linter/tests/jsonlint/24.lint-test

src/lint/linter/tests/jsonlint/25.lint-test

src/lint/linter/tests/jsonlint/26.lint-test

src/lint/linter/tests/jsonlint/27.lint-test

src/lint/linter/tests/jsonlint/28.lint-test

src/lint/linter/tests/jsonlint/29.lint-test

src/lint/linter/tests/jsonlint/3.lint-test

src/lint/linter/tests/jsonlint/30.lint-test

src/lint/linter/tests/jsonlint/31.lint-test

src/lint/linter/tests/jsonlint/32.lint-test

src/lint/linter/tests/jsonlint/33.lint-test

src/lint/linter/tests/jsonlint/34.lint-test

src/lint/linter/tests/jsonlint/4.lint-test

src/lint/linter/tests/jsonlint/5.lint-test

src/lint/linter/tests/jsonlint/6.lint-test

src/lint/linter/tests/jsonlint/7.lint-test

src/lint/linter/tests/jsonlint/8.lint-test

src/lint/linter/tests/jsonlint/9.lint-test

src/lint/linter/xhpast/rules/tests/ArcanistXHPASTLinterRuleTestCase.php

src/moduleutils/PhutilLibraryMapBuilder.php

src/parser/PhutilEditorConfig.php

src/parser/PhutilJSONParser.php

src/phage/tests/PhageAgentTestCase.php

src/symbols/PhutilClassMapQuery.php

src/symbols/PhutilSymbolLoader.php

src/unit/engine/phutil/PhutilTestCase.php

src/utils/PhutilExecutionEnvironment.php

src/utils/tests/PhutilUTF8TestCase.php

src/utils/tests/PhutilUtilsTestCase.php

src/utils/utf8.php

src/utils/utils.php

src/xsprintf/PhutilTerminalString.php

src/xsprintf/tests/PhutilCsprintfTestCase.php

support/init/init-script.php

support/lib/extract-symbols.php

support/lib/rebuild-map.php

support/shell/hooks/bash-completion.sh

support/shell/rules/.keep

support/shell/templates/bash-template.sh

support/test/lock-file.php

support/unit/cat.php

support/unit/echo.php

support/unit/exit.php

support/unit/lock.php

support/unit/sleep.php

support/xhpast/build-xhpast.php