Paths

Table of Contentst

Differential D20987

Merge the remainder of the "experimental" branch
ClosedPublic
Actions

Authored by epriestley on Feb 13 2020, 2:03 PM.

Tags

None

Referenced Files

	F14842009: D20987.id50008.diff
	Sat, Feb 1, 8:18 PM

	Unknown Object (File)
	Tue, Jan 28, 5:26 AM

	Unknown Object (File)
	Mon, Jan 27, 7:45 AM

	Unknown Object (File)
	Mon, Jan 27, 2:02 AM

	Unknown Object (File)
	Sat, Jan 25, 6:34 AM

	Unknown Object (File)
	Sat, Jan 25, 6:34 AM

	Unknown Object (File)
	Sat, Jan 25, 6:34 AM

	Unknown Object (File)
	Thu, Jan 23, 3:19 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13395: Strip libphutil for parts
Commits: rARC8c4f6ce1617e: Merge the remainder of the "experimental" branch

Summary

Depends on D20986. Ref T13395. This mostly collapses the entire "experimental" branch into "master".

I plan to change the "Ref/Hardpoint" pattern to become future oriented, but this is more steps forward than sideways.

Test Plan

Ran various arc workflows.

Diff Detail

Repository

Branch

exp2

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/browse/loader/ArcanistBrowseCommitHardpointLoader.php:50	XHP16	TODO Comment
Advice	src/browse/workflow/ArcanistBrowseWorkflow.php:87	XHP16	TODO Comment
Advice	src/ref/ArcanistRepositoryRef.php:67	XHP16	TODO Comment
Advice	src/ref/ArcanistRepositoryRef.php:74	XHP16	TODO Comment
Advice	src/ref/ArcanistRevisionRef.php:32	XHP16	TODO Comment
Advice	src/ref/ArcanistWorkingCopyStateRef.php:9	XHP16	TODO Comment
Advice	src/repository/api/ArcanistGitAPI.php:1136	XHP16	TODO Comment
Advice	src/workflow/ArcanistFeatureWorkflow.php:81	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 23832
Build 32782: Run Core Tests
Build 32781: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 13 2020, 2:03 PM

Harbormaster completed remote builds in B23832: Diff 50006.Feb 13 2020, 2:04 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2020, 2:04 PM

epriestley requested review of this revision.

Closed by commit rARC8c4f6ce1617e: Merge the remainder of the "experimental" branch (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC8c4f6ce1617e: Merge the remainder of the "experimental" branch.

Revision Contents
Changeset List

Path

Size

scripts/

28 lines

src/

__phutil_library_map__.php

browse/

loader/

ArcanistBrowseCommitHardpointLoader.php

80 lines

ArcanistBrowseCommitURIHardpointLoader.php

92 lines

ArcanistBrowseObjectNameURIHardpointLoader.php

54 lines

ArcanistBrowsePathURIHardpointLoader.php

132 lines

ArcanistBrowseRevisionURIHardpointLoader.php

78 lines

ArcanistBrowseURIHardpointLoader.php

55 lines

ref/

ArcanistBrowseRef.php

72 lines

ArcanistBrowseURIRef.php

35 lines

workflow/

ArcanistBrowseWorkflow.php

259 lines

conduit/

ArcanistConduitCall.php

155 lines

ArcanistConduitEngine.php

166 lines

configuration/

ArcanistSetting.php

48 lines

ArcanistSettings.php

25 lines

loader/

ArcanistCommitUpstreamHardpointLoader.php

59 lines

ArcanistGitCommitMessageHardpointLoader.php

41 lines

ArcanistGitHardpointLoader.php

10 lines

ArcanistGitRevisionHardpointLoader.php

82 lines

ArcanistHardpointLoader.php

76 lines

ArcanistMercurialBranchCommitHardpointLoader.php

49 lines

ArcanistMercurialHardpointLoader.php

10 lines

ArcanistMercurialWorkingCopyCommitHardpointLoader.php

36 lines

ArcanistMessageRevisionHardpointLoader.php

82 lines

ref/

ArcanistBranchRef.php

57 lines

ArcanistCommitRef.php

94 lines

ArcanistRef.php

106 lines

ArcanistRefQuery.php

188 lines

ArcanistRepositoryRef.php

79 lines

ArcanistRevisionRef.php

72 lines

ArcanistRevisionRefSource.php

4 lines

ArcanistWorkingCopyStateRef.php

122 lines

repository/

api/

ArcanistGitAPI.php

46 lines

ArcanistMercurialAPI.php

27 lines

ArcanistRepositoryAPI.php

21 lines

workflow/

ArcanistBrowseWorkflow.php

ArcanistDiffWorkflow.php

51 lines

ArcanistFeatureWorkflow.php

201 lines

ArcanistUpgradeWorkflow.php

21 lines

ArcanistWorkflow.php

72 lines

Diff 50006

scripts/arcanist.php

Loading...

src/__phutil_library_map__.php

Loading...

src/browse/loader/ArcanistBrowseCommitHardpointLoader.php

Loading...

src/browse/loader/ArcanistBrowseCommitURIHardpointLoader.php

Loading...

src/browse/loader/ArcanistBrowseObjectNameURIHardpointLoader.php

Loading...

src/browse/loader/ArcanistBrowsePathURIHardpointLoader.php

Loading...

src/browse/loader/ArcanistBrowseRevisionURIHardpointLoader.php

Loading...

src/browse/loader/ArcanistBrowseURIHardpointLoader.php

Loading...

src/browse/ref/ArcanistBrowseRef.php

Loading...

src/browse/ref/ArcanistBrowseURIRef.php

Loading...

src/browse/workflow/ArcanistBrowseWorkflow.php

Loading...

src/conduit/ArcanistConduitCall.php

Loading...

src/conduit/ArcanistConduitEngine.php

Loading...

src/configuration/ArcanistSetting.php

Loading...

src/configuration/ArcanistSettings.php

Loading...

src/loader/ArcanistCommitUpstreamHardpointLoader.php

Loading...

src/loader/ArcanistGitCommitMessageHardpointLoader.php

Loading...

src/loader/ArcanistGitHardpointLoader.php

Loading...

src/loader/ArcanistGitRevisionHardpointLoader.php

Loading...

src/loader/ArcanistHardpointLoader.php

Loading...

src/loader/ArcanistMercurialBranchCommitHardpointLoader.php

Loading...

src/loader/ArcanistMercurialHardpointLoader.php

Loading...

src/loader/ArcanistMercurialWorkingCopyCommitHardpointLoader.php

Loading...

src/loader/ArcanistMessageRevisionHardpointLoader.php

Loading...

src/ref/ArcanistBranchRef.php

Loading...

src/ref/ArcanistCommitRef.php

Loading...

src/ref/ArcanistRef.php

Loading...

src/ref/ArcanistRefQuery.php

Loading...

src/ref/ArcanistRepositoryRef.php

Loading...

src/ref/ArcanistRevisionRef.php

Loading...

src/ref/ArcanistRevisionRefSource.php

Loading...

src/ref/ArcanistWorkingCopyStateRef.php

Loading...

src/repository/api/ArcanistGitAPI.php

Loading...

src/repository/api/ArcanistMercurialAPI.php

Loading...

src/repository/api/ArcanistRepositoryAPI.php

Loading...

src/workflow/ArcanistBrowseWorkflow.php

Loading...

src/workflow/ArcanistDiffWorkflow.php

Loading...

src/workflow/ArcanistFeatureWorkflow.php

Loading...

src/workflow/ArcanistUpgradeWorkflow.php

Loading...

src/workflow/ArcanistWorkflow.php

Loading...