Page MenuHomePhabricator
Differential D20984

Make "arcanist/" unit tests pass
ClosedPublic
Actions

Authored by epriestley on Feb 12 2020, 11:58 PM.
Tags
None
Referenced Files
F18377599: D20984.diff
Thu, Aug 28, 1:15 PM
F18100869: D20984.id.diff
Sat, Aug 9, 12:08 PM
F17914829: D20984.diff
Jul 29 2025, 7:46 PM
F17914098: D20984.id50001.diff
Jul 29 2025, 6:52 PM
F17853774: D20984.id.diff
Jul 27 2025, 2:19 PM
F17840467: D20984.id50000.diff
Jul 26 2025, 9:10 PM
Unknown Object (File)
Jun 27 2025, 5:10 PM
Unknown Object (File)
Jun 17 2025, 6:55 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13395: Strip libphutil for parts
Commits
rARCa8a50b2fc004: Make "arcanist/" unit tests pass
Summary

Ref T13395. Fixes a file-locking test and removes a logging test that's more trouble than it's worth.

Test Plan

Ran "arc unit --everything" locally, got a clean bill of health.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 12 2020, 11:58 PM
Harbormaster completed remote builds in B23826: Diff 50000.Feb 12 2020, 11:59 PM
epriestley requested review of this revision.Feb 12 2020, 11:59 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2020, 12:20 AM
Closed by commit rARCa8a50b2fc004: Make "arcanist/" unit tests pass (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARCa8a50b2fc004: Make "arcanist/" unit tests pass.

Revision Contents
Changeset List

PathSize
src/
filesystem/
__tests__/
22 lines
6 lines
support/
test/
82 lines

Diff 50001

View Options

src/filesystem/__tests__/PhutilDeferredLogTestCase.php

Loading...
View Options

src/filesystem/__tests__/PhutilFileLockTestCase.php

Loading...
View Options

support/test/lock-file.php

Loading...
Phabricator · Built by Phacility