Page MenuHomePhabricator
Differential D20984

Make "arcanist/" unit tests pass
ClosedPublic
Actions

Authored by epriestley on Feb 12 2020, 11:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 1, 2:41 AM
Unknown Object (File)
Tue, Jun 30, 10:13 AM
Unknown Object (File)
Mar 16 2026, 6:36 PM
Unknown Object (File)
Mar 6 2026, 6:41 AM
Unknown Object (File)
Feb 25 2026, 1:42 PM
Unknown Object (File)
Feb 25 2026, 1:34 PM
Unknown Object (File)
Feb 4 2026, 8:02 AM
Unknown Object (File)
Feb 3 2026, 11:31 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13395: Strip libphutil for parts
Commits
rARCa8a50b2fc004: Make "arcanist/" unit tests pass
Summary

Ref T13395. Fixes a file-locking test and removes a logging test that's more trouble than it's worth.

Test Plan

Ran "arc unit --everything" locally, got a clean bill of health.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 12 2020, 11:58 PM
Harbormaster completed remote builds in B23826: Diff 50000.Feb 12 2020, 11:59 PM
epriestley requested review of this revision.Feb 12 2020, 11:59 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2020, 12:20 AM
Closed by commit rARCa8a50b2fc004: Make "arcanist/" unit tests pass (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARCa8a50b2fc004: Make "arcanist/" unit tests pass.

Revision Contents
Changeset List

PathSize
src/
filesystem/
__tests__/
22 lines
6 lines
support/
test/
82 lines

Diff 50001

View Options

src/filesystem/__tests__/PhutilDeferredLogTestCase.php

Loading...
View Options

src/filesystem/__tests__/PhutilFileLockTestCase.php

Loading...
View Options

support/test/lock-file.php

Loading...
Phabricator · Built by Phacility