Page MenuHomePhabricator

Merge a small amount of remaining "libphutil/" code with Phabricator, break libphutil dependency
ClosedPublic

Authored by epriestley on Wed, Feb 12, 11:11 PM.

Details

Summary

Ref T13395. Moves a small amount of remaining "libphutil/" code into "phabricator/" and stops us from loading "libphutil/".

Test Plan

Browsed around; there are likely remaining issues.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, Feb 12, 11:11 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Feb 12, 11:12 PM
Harbormaster failed remote builds in B23818: Diff 49992!
  • Adjustments to daemons.
Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Feb 12, 11:15 PM
Harbormaster failed remote builds in B23819: Diff 49993!
epriestley requested review of this revision.Wed, Feb 12, 11:17 PM

Depends on harness changes to even plausibly build.

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Feb 12, 11:17 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.