Page MenuHomePhabricator

Merge a small amount of remaining "libphutil/" code with Phabricator, break libphutil dependency
ClosedPublic

Authored by epriestley on Feb 12 2020, 11:11 PM.
Tags
None
Referenced Files
F13086202: D20981.diff
Thu, Apr 25, 12:06 AM
Unknown Object (File)
Sat, Apr 20, 5:03 PM
Unknown Object (File)
Tue, Apr 16, 7:40 PM
Unknown Object (File)
Thu, Apr 11, 8:23 AM
Unknown Object (File)
Fri, Mar 29, 11:32 AM
Unknown Object (File)
Mar 23 2024, 12:49 PM
Unknown Object (File)
Mar 23 2024, 12:49 PM
Unknown Object (File)
Mar 23 2024, 12:49 PM
Subscribers
None

Details

Summary

Ref T13395. Moves a small amount of remaining "libphutil/" code into "phabricator/" and stops us from loading "libphutil/".

Test Plan

Browsed around; there are likely remaining issues.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 12 2020, 11:12 PM
Harbormaster failed remote builds in B23818: Diff 49992!
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 12 2020, 11:15 PM
Harbormaster failed remote builds in B23819: Diff 49993!

Depends on harness changes to even plausibly build.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 12 2020, 11:17 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.