Differential D20936

Pass context object to PhabricatorMetaMTAMailBody as this is done in parent class
AbandonedPublic
Actions

Authored by epriestley on Dec 9 2019, 11:31 AM.

Tags

None

Referenced Files

	F13044188: D20936.diff
	Wed, Apr 17, 3:10 PM

	Unknown Object (File)
	Thu, Apr 11, 7:19 AM

	Unknown Object (File)
	Fri, Apr 5, 7:32 PM

	Unknown Object (File)
	Sat, Mar 23, 4:09 AM

	Unknown Object (File)
	Feb 8 2024, 6:54 PM

	Unknown Object (File)
	Feb 3 2024, 11:29 PM

	Unknown Object (File)
	Dec 21 2023, 10:27 AM

	Unknown Object (File)
	Dec 17 2023, 8:33 AM

View All 59 Files

Subscribers

Korvin

Details

Reviewers

Pawka
artms

Group Reviewers

Blessed Reviewers

Summary

PhabricatorApplicationTransactionEditor method buildMailBody passed context object to PhabricatorMetaMTAMailBody, do the same in DifferentialTransactionEditor.

Test Plan

Made changes, checked that PhabricatorMetaMTAMailBody contains context object when differential revision changes happen

Diff Detail

Repository

rP Phabricator

Branch

context

Lint

Lint Passed

Unit

Tests Skipped

Build Status

Buildable 23711
Build 32602: Run Core Tests
Build 32601: arc lint + arc unit

Event Timeline

artms created this revision.Dec 9 2019, 11:31 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 9 2019, 11:31 AM

Harbormaster completed remote builds in B23711: Diff 49886.Dec 9 2019, 11:32 AM

artms requested review of this revision.Dec 9 2019, 11:32 AM

Herald added a subscriber: Korvin. · View Herald TranscriptDec 9 2019, 11:32 AM

I'm not sure if this is a feature request, a bug report, or something else. Please file via Discourse and/or your support channel, don't send patches.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

3 lines

Diff 49886

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Pass context object to PhabricatorMetaMTAMailBody as this is done in parent classAbandonedPublicActions