Paths

Table of Contentst

Differential D20915

When "arc close-revision --finalize ..." skips closing a revision, print a message
ClosedPublic
Actions

Authored by epriestley on Nov 19 2019, 4:30 AM.

Tags

None

Referenced Files

	F15428312: D20915.id.diff
	Sun, Mar 23, 7:07 PM

	F15418387: D20915.diff
	Thu, Mar 20, 10:59 PM

	F15415989: D20915.id49837.diff
	Thu, Mar 20, 8:36 AM

	F15399524: D20915.id.diff
	Mon, Mar 17, 5:00 AM

	F15387793: D20915.id49838.diff
	Sat, Mar 15, 2:55 AM

	Unknown Object (File)
	Mon, Feb 24, 9:14 PM

	Unknown Object (File)
	Feb 19 2025, 2:16 AM

	Unknown Object (File)
	Feb 19 2025, 2:04 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13458: When "arc land" calls "arc close-revision" but declines to act because the revision is not "Accepted", emit a message
Commits: rARCbac2028421a4: (stable) Promote 2019 Week 46
rARCe19fe12f7ecd: (experimental) When "arc close-revision --finalize ..." skips closing a…
rARCcc850163f30c: When "arc close-revision --finalize ..." skips closing a revision, print a…

Summary

Fixes T13458. Emit an explicit message when "arc close-revision --finalize" bails out because the revision is not "Accepted".

Test Plan

Ran arc close-revision [--finalize] ... on various revisions, saw more clear messaging.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Nov 19 2019, 4:30 AM

Harbormaster completed remote builds in B23665: Diff 49837.Nov 19 2019, 4:31 AM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 19 2019, 4:31 AM

epriestley requested review of this revision.

Closed by commit rARCcc850163f30c: When "arc close-revision --finalize ..." skips closing a revision, print a… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCcc850163f30c: When "arc close-revision --finalize ..." skips closing a revision, print a….

epriestley added a commit: rARCe19fe12f7ecd: (experimental) When "arc close-revision --finalize ..." skips closing a….Nov 19 2019, 5:12 AM

epriestley added a commit: rARCbac2028421a4: (stable) Promote 2019 Week 46.Nov 19 2019, 5:29 PM

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistCloseRevisionWorkflow.php

49 lines

Diff 49838

src/workflow/ArcanistCloseRevisionWorkflow.php

Loading...