Paths

Table of Contentst

Differential D20915

When "arc close-revision --finalize ..." skips closing a revision, print a message
ClosedPublic
Actions

Authored by epriestley on Nov 19 2019, 4:30 AM.

Tags

None

Referenced Files

	F18842341: D20915.id.diff
	Tue, Oct 28, 3:07 PM

	F18839423: D20915.diff
	Mon, Oct 27, 4:14 PM

	F18763471: D20915.id.diff
	Tue, Oct 7, 12:20 AM

	F18741360: D20915.diff
	Thu, Oct 2, 11:57 AM

	F18567556: D20915.id.diff
	Sep 9 2025, 3:55 PM

	F18100806: D20915.id.diff
	Aug 9 2025, 12:06 PM

	F17941016: D20915.id49838.diff
	Jul 31 2025, 4:58 AM

	F17914852: D20915.id49838.diff
	Jul 29 2025, 7:48 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13458: When "arc land" calls "arc close-revision" but declines to act because the revision is not "Accepted", emit a message
Commits: rARCbac2028421a4: (stable) Promote 2019 Week 46
rARCe19fe12f7ecd: (experimental) When "arc close-revision --finalize ..." skips closing a…
rARCcc850163f30c: When "arc close-revision --finalize ..." skips closing a revision, print a…

Summary

Fixes T13458. Emit an explicit message when "arc close-revision --finalize" bails out because the revision is not "Accepted".

Test Plan

Ran arc close-revision [--finalize] ... on various revisions, saw more clear messaging.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Nov 19 2019, 4:30 AM

Harbormaster completed remote builds in B23665: Diff 49837.Nov 19 2019, 4:31 AM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 19 2019, 4:31 AM

epriestley requested review of this revision.

Closed by commit rARCcc850163f30c: When "arc close-revision --finalize ..." skips closing a revision, print a… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCcc850163f30c: When "arc close-revision --finalize ..." skips closing a revision, print a….

epriestley added a commit: rARCe19fe12f7ecd: (experimental) When "arc close-revision --finalize ..." skips closing a….Nov 19 2019, 5:12 AM

epriestley added a commit: rARCbac2028421a4: (stable) Promote 2019 Week 46.Nov 19 2019, 5:29 PM

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistCloseRevisionWorkflow.php

49 lines

Diff 49838

src/workflow/ArcanistCloseRevisionWorkflow.php

Loading...