When a large number of commits need to be marked as published, issue the lookup query in chunks
ClosedPublic
Actions

Authored by epriestley on Oct 2 2019, 8:11 PM.

Details

Reviewers: None
Commits: rPed7d22142a99: (stable) When a large number of commits need to be marked as published, issue…
rP6d74736a7ec8: When a large number of commits need to be marked as published, issue the lookup…

Summary

See PHI1474. This query can become large enough to exceed reasonable packet limits. Chunk the query so it is split up if we have too many identifiers.

Test Plan

Ran bin/repository refs ... on a repository with no new commits and a repository with some new commits.

Diff Detail

Repository

rP Phabricator

Branch

ref1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23540
Build 32351: Run Core Tests
Build 32350: arc lint + arc unit

Event Timeline

epriestley created this revision.Oct 2 2019, 8:11 PM

Harbormaster completed remote builds in B23540: Diff 49712.Oct 2 2019, 8:13 PM

epriestley requested review of this revision.Oct 2 2019, 8:13 PM

epriestley added a child revision: D20854: Use "git log ... --stdin" instead of "git log ... --not ..." to avoid oversized command lines.Oct 2 2019, 8:28 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 2 2019, 9:06 PM

Closed by commit rP6d74736a7ec8: When a large number of commits need to be marked as published, issue the lookup… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP6d74736a7ec8: When a large number of commits need to be marked as published, issue the lookup….

epriestley added a commit: rPed7d22142a99: (stable) When a large number of commits need to be marked as published, issue….Oct 2 2019, 9:12 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

engine/

PhabricatorRepositoryRefEngine.php

32 lines

Diff 49712

View Options

src/applications/repository/engine/PhabricatorRepositoryRefEngine.php

When a large number of commits need to be marked as published, issue the lookup query in chunksClosedPublicActions