Differential D20799

When a project has a custom icon, use that icon to label the project policy in the policy dropown
ClosedPublic
Actions

Authored by epriestley on Sep 9 2019, 8:35 PM.

Details

Reviewers: None
Maniphest Tasks: T8808: Policy menu should show actual project icon next to project
Commits: rPd2e1c4163a3b: When a project has a custom icon, use that icon to label the project policy in…

Summary

Fixes T8808. Currently, all project use the default ("Briefcase") project icon when they appear in a policy dropdown.

Since project policies are separated out into a "Members of Projects" section of the dropdown anyway, there is no reason not to use the actual project icon, which is often more clear.

Test Plan

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 9 2019, 8:35 PM

Harbormaster completed remote builds in B23418: Diff 49593.Sep 9 2019, 8:37 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 8:37 PM

epriestley requested review of this revision.

Closed by commit rPd2e1c4163a3b: When a project has a custom icon, use that icon to label the project policy in… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPd2e1c4163a3b: When a project has a custom icon, use that icon to label the project policy in….

Revision Contents
Changeset List

Path

Size

src/

applications/

policy/

storage/

PhabricatorPolicy.php

6 lines

Diff 49594

View Options

src/applications/policy/storage/PhabricatorPolicy.php

When a project has a custom icon, use that icon to label the project policy in the policy dropownClosedPublicActions