Page MenuHomePhabricator

Correct the interaction between overheating and offset-based paging
ClosedPublic

Authored by epriestley on Aug 22 2019, 3:16 AM.
Tags
None
Referenced Files
F13181013: D20728.id49420.diff
Thu, May 9, 7:09 AM
F13179657: D20728.diff
Wed, May 8, 9:21 PM
Unknown Object (File)
Tue, May 7, 5:43 PM
Unknown Object (File)
Sat, May 4, 6:56 PM
Unknown Object (File)
Wed, May 1, 12:23 AM
Unknown Object (File)
Fri, Apr 26, 2:16 AM
Unknown Object (File)
Tue, Apr 16, 2:32 AM
Unknown Object (File)
Apr 9 2024, 3:09 PM
Subscribers
None

Details

Summary

Ref T13386. If you issue differential.query with a large offset (like 3000), it can overheat regardless of policy filtering and fail with a nonsensical error message.

This is because the overheating limit is based only on the query limit, not on the offset.

For example, querying for "limit = 100" will never examine more than 1,100 rows, so a query with "limit = 100, offset = 3000" will always fail (provided there are at least that many revisions).

Not all numbers work like you might expect them to becuase there's also a 1024-row fetch window, but basically small limits plus big offsets always fail.

Test Plan

Artificially reduced the internal window size from 1024 to 5, then ran differential.query with offset=50 and limit=3. Before: overheated with weird error message. After: clean result.

Diff Detail

Repository
rP Phabricator
Branch
overheat1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23278
Build 31984: Run Core Tests
Build 31983: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 22 2019, 3:27 AM
This revision was automatically updated to reflect the committed changes.