Differential D20689

Don't try to emit project board update events if there are no projects to update
ClosedPublic
Actions

Authored by epriestley on Jul 31 2019, 7:42 PM.

Details

Reviewers: None
Maniphest Tasks: T4900: Workboards updating in real time
Commits: rP8e1600ba83fd: (stable) Don't try to emit project board update events if there are no projects…
rP76cd181bf379: Don't try to emit project board update events if there are no projects to update

Summary

Ref T4900. We may execute a bad query here if the task has no projects at all.

Test Plan

Edited a task with no new or old projects. Instead of an exception, things worked.

Diff Detail

Repository

rP Phabricator

Branch

cfield1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23209
Build 31879: Run Core Tests
Build 31878: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 31 2019, 7:42 PM

Harbormaster completed remote builds in B23209: Diff 49344.Jul 31 2019, 7:43 PM

epriestley requested review of this revision.Jul 31 2019, 7:43 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 31 2019, 7:48 PM

Closed by commit rP76cd181bf379: Don't try to emit project board update events if there are no projects to update (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP76cd181bf379: Don't try to emit project board update events if there are no projects to update.

epriestley added a commit: rP8e1600ba83fd: (stable) Don't try to emit project board update events if there are no projects….

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

editor/

ManiphestTransactionEditor.php

44 lines

Diff 49344

View Options

src/applications/maniphest/editor/ManiphestTransactionEditor.php

Don't try to emit project board update events if there are no projects to updateClosedPublicActions