Page MenuHomePhabricator

Export "date" and "remarkup" custom fields to Excel + "zip" extension check
ClosedPublic

Authored by epriestley on Jul 17 2019, 10:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 9:55 AM
Unknown Object (File)
Thu, Mar 14, 5:32 PM
Unknown Object (File)
Sat, Mar 2, 3:06 PM
Unknown Object (File)
Feb 3 2024, 10:55 PM
Unknown Object (File)
Jan 25 2024, 1:37 PM
Unknown Object (File)
Jan 14 2024, 7:13 PM
Unknown Object (File)
Dec 28 2023, 1:44 AM
Unknown Object (File)
Dec 13 2023, 9:38 PM
Subscribers
None

Details

Summary

Fixes T13342. This does a few different things, although all of them seem small enough that I didn't bother splitting it up:

  • Support export of "remarkup" custom fields as text. There's some argument here to export them in some kind of structure if the target is JSON, but it's hard for me to really imagine we'll live in a world some day where we really regret just exporting them as text.
  • Support export of "date" custom fields as dates. This is easy except that I added null support.
  • If you built PHP from source without "--enable-zip", as I did, you can hit the TODO in Excel exports about "ZipArchive". Since I had a reproduction case, test for "ZipArchive" and give the user a better error if it's missing.
  • Add a setup check for the "zip" extension to try to avoid getting there in the first place. This is normally part of PHP so I believe users generally won't hit it, I just hit it because I built from source. See also T13232.
Test Plan
  • Added a custom "date" field. On tasks A and B, set it to null and some non-null value. Exported both tasks to Excel/JSON/text, saw null and a date, respectively.
  • Added a custom "remarkup" field, exported some values, saw the values in Excel.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable