Page MenuHomePhabricator

Replace weird, redundant list of branches in Diffusion "Manage" UI with a link to the main branch list
ClosedPublic

Authored by epriestley on Jun 17 2019, 5:52 PM.
Tags
None
Referenced Files
F13184305: D20584.id49090.diff
Fri, May 10, 5:24 PM
F13177085: D20584.diff
Wed, May 8, 7:15 PM
Unknown Object (File)
Tue, May 7, 7:42 AM
Unknown Object (File)
Sun, May 5, 5:27 PM
Unknown Object (File)
Fri, May 3, 7:19 AM
Unknown Object (File)
Thu, May 2, 4:31 PM
Unknown Object (File)
Wed, May 1, 9:10 AM
Unknown Object (File)
Thu, Apr 25, 1:28 AM
Subscribers
None

Details

Summary

Fixes T13312. Currently, ManageBranches has a list of branches on the same page. This has a few minor issues:

  • Pager is at the top (see T13312), which is weird.
  • "Default" icon is mystery meat.
  • Table is kind of pointless/redundant in general?

Previously, this table had more information about technical status of each branch (autoclose/track/publish) but most of these details have been simplified/eliminated, and the main "Branches" view now has more information than it did before.

Get rid of this and just link to the main view.

Test Plan

Viewed "Branches" in UI, saw a link to the main view instead of a weird table.

Diff Detail

Repository
rP Phabricator
Branch
branches1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22965
Build 31519: Run Core Tests
Build 31518: arc lint + arc unit