diff --git a/src/applications/audit/editor/PhabricatorAuditEditor.php b/src/applications/audit/editor/PhabricatorAuditEditor.php --- a/src/applications/audit/editor/PhabricatorAuditEditor.php +++ b/src/applications/audit/editor/PhabricatorAuditEditor.php @@ -485,6 +485,10 @@ return $phids; } + protected function getObjectLinkButtonLabelForMail() { + return pht('View Commit'); + } + protected function buildMailBody( PhabricatorLiskDAO $object, array $xactions) { diff --git a/src/applications/differential/editor/DifferentialTransactionEditor.php b/src/applications/differential/editor/DifferentialTransactionEditor.php --- a/src/applications/differential/editor/DifferentialTransactionEditor.php +++ b/src/applications/differential/editor/DifferentialTransactionEditor.php @@ -601,6 +601,10 @@ return $xactions; } + protected function getObjectLinkButtonLabelForMail() { + return pht('View Revision'); + } + protected function buildMailBody( PhabricatorLiskDAO $object, array $xactions) { @@ -617,7 +621,7 @@ $this->addHeadersAndCommentsToMailBody( $body, $xactions, - pht('View Revision'), + $this->getObjectLinkButtonLabelForMail($object), $revision_uri); $type_inline = DifferentialTransaction::TYPE_INLINE; diff --git a/src/applications/maniphest/editor/ManiphestTransactionEditor.php b/src/applications/maniphest/editor/ManiphestTransactionEditor.php --- a/src/applications/maniphest/editor/ManiphestTransactionEditor.php +++ b/src/applications/maniphest/editor/ManiphestTransactionEditor.php @@ -206,6 +206,10 @@ ->setSubject("T{$id}: {$title}"); } + protected function getObjectLinkButtonLabelForMail() { + return pht('View Task'); + } + protected function buildMailBody( PhabricatorLiskDAO $object, array $xactions) { diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php --- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php +++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php @@ -3417,12 +3417,17 @@ ->setViewer($this->requireActor()) ->setContextObject($object); - $this->addHeadersAndCommentsToMailBody($body, $xactions); + $button_label = $this->getObjectLinkButtonLabelForMail($object); + + $this->addHeadersAndCommentsToMailBody($body, $xactions, $button_label); $this->addCustomFieldsToMailBody($body, $object, $xactions); return $body; } + protected function getObjectLinkButtonLabelForMail() { + return null; + } /** * @task mail