Differential D20485

Add a rough "Chart" Dashboard Panel
ClosedPublic
Actions

Authored by epriestley on Apr 30 2019, 3:36 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13279: Build Charting for Facts

Commits

rPff6b13872ccf: Add a rough "Chart" Dashboard Panel

Summary

Depends on D20484. Ref T13279. Allows a chart to render as a panel.

Configuring these is currently quite low-level (you have to manually copy/paste a chart key in), but works well enough.

Test Plan

Screen Shot 2019-04-29 at 11.30.52 AM.png (1×1 px, 486 KB)

Diff Detail

Repository

rP Phabricator

Branch

chart14

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22740
Build 31176: Run Core Tests
Build 31175: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 30 2019, 3:36 PM

Herald added a subscriber: yelirekim. · View Herald TranscriptApr 30 2019, 3:36 PM

Harbormaster completed remote builds in B22740: Diff 48867.Apr 30 2019, 3:38 PM

epriestley requested review of this revision.Apr 30 2019, 3:38 PM

epriestley added a child revision: D20486: Replace the chart in Maniphest Reports with a chart driven by Facts.Apr 30 2019, 3:42 PM

amckinley accepted this revision.May 21 2019, 8:36 PM

This revision is now accepted and ready to land.May 21 2019, 8:36 PM

Closed by commit rPff6b13872ccf: Add a rough "Chart" Dashboard Panel (authored by epriestley). · Explain WhyMay 22 2019, 11:36 AM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPff6b13872ccf: Add a rough "Chart" Dashboard Panel.

epriestley mentioned this in rPff6b13872ccf: Add a rough "Chart" Dashboard Panel.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

dashboard/

paneltype/

PhabricatorDashboardChartPanelType.php

76 lines

xaction/

panel/

PhabricatorDashboardChartPanelChartTransaction.php

12 lines

fact/

controller/

PhabricatorFactChartController.php

11 lines

engine/

PhabricatorChartEngine.php

18 lines

Diff 48867

View Options

src/__phutil_library_map__.php

View Options

src/applications/dashboard/paneltype/PhabricatorDashboardChartPanelType.php

View Options

src/applications/dashboard/xaction/panel/PhabricatorDashboardChartPanelChartTransaction.php

View Options

src/applications/fact/controller/PhabricatorFactChartController.php

View Options

src/applications/fact/engine/PhabricatorChartEngine.php

Add a rough "Chart" Dashboard PanelClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48867

src/__phutil_library_map__.php

src/applications/dashboard/paneltype/PhabricatorDashboardChartPanelType.php

src/applications/dashboard/xaction/panel/PhabricatorDashboardChartPanelChartTransaction.php

src/applications/fact/controller/PhabricatorFactChartController.php

src/applications/fact/engine/PhabricatorChartEngine.php

Add a rough "Chart" Dashboard Panel
ClosedPublic
Actions

Revision Contents
Changeset List