Remove obsolete Dashboard panel methods with no callsites
ClosedPublic
Actions

Authored by epriestley on Apr 30 2019, 3:34 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13272: Remove the hard-coded homepage, and other Dashboards improvements

Commits

rPa76e91ea9ef6: Remove obsolete Dashboard panel methods with no callsites

Summary

Ref T13272. Since the move to EditEngine, these methods have no callsites.

Test Plan

grep

Diff Detail

Repository

rP Phabricator

Branch

chart13

Lint

Lint OK

Unit

Unit Tests OK

Build Status

Buildable 22739
Build 31174: Run Core Tests
Build 31173: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 30 2019, 3:34 PM

Harbormaster completed remote builds in B22739: Diff 48866.Apr 30 2019, 3:36 PM

epriestley requested review of this revision.Apr 30 2019, 3:36 PM

epriestley added a child revision: D20485: Add a rough "Chart" Dashboard Panel.Apr 30 2019, 3:36 PM

amckinley accepted this revision.May 1 2019, 2:32 PM

This revision is now accepted and ready to land.May 1 2019, 2:32 PM

Closed by commit rPa76e91ea9ef6: Remove obsolete Dashboard panel methods with no callsites (authored by epriestley). · Explain WhyMay 17 2019, 7:09 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPa76e91ea9ef6: Remove obsolete Dashboard panel methods with no callsites.

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

paneltype/

PhabricatorDashboardPanelType.php

7 lines

PhabricatorDashboardQueryPanelType.php

27 lines

Diff 48866

View Options

src/applications/dashboard/paneltype/PhabricatorDashboardPanelType.php