Differential D20474

Add a "Customize Query" action to query panels to make it easier to make minor query adjustments
ClosedPublic
Actions

Authored by epriestley on Apr 25 2019, 6:05 PM.

Details

Reviewers

Maniphest Tasks

T7216: Make it easier to update the ApplicationSearch saved query used by a dashboard panel
T13272: Remove the hard-coded homepage, and other Dashboards improvements

Summary

Depends on D20473. Ref T13272. Fixes T7216. If you want to tweak the query a panel uses, you currently have to complete 7 Great Labors.

Instead, add a "Customize Query" action which lets you update the query inline.

Test Plan

Screen Shot 2019-04-25 at 11.05.18 AM.png (1×2 px, 502 KB)

Diff Detail

Repository

rP Phabricator

Branch

panel3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22721
Build 31144: Run Core Tests
Build 31143: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 25 2019, 6:05 PM

Harbormaster completed remote builds in B22721: Diff 48846.Apr 25 2019, 6:07 PM

epriestley requested review of this revision.Apr 25 2019, 6:07 PM

epriestley added a child revision: D20475: Add "Move Left" and "Move Right" to dashboard tab panels.Apr 25 2019, 6:39 PM

amckinley accepted this revision.May 1 2019, 2:36 PM

This revision is now accepted and ready to land.May 1 2019, 2:36 PM

Closed by commit rP9d716379a3f1: Add a "Customize Query" action to query panels to make it easier to make minor… (authored by epriestley). · Explain WhyMay 1 2019, 6:01 PM

This revision was automatically updated to reflect the committed changes.

epriestley added an edge: rP9d716379a3f1: Add a "Customize Query" action to query panels to make it easier to make minor….

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

engine/

PhabricatorDashboardPanelRenderingEngine.php

12 lines

paneltype/

PhabricatorDashboardPanelType.php

7 lines

PhabricatorDashboardQueryPanelType.php

22 lines

storage/

PhabricatorDashboardPanel.php

9 lines

search/

controller/

PhabricatorApplicationSearchController.php

106 lines

engine/

PhabricatorApplicationSearchEngine.php

13 lines

Diff 48846

View Options

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

View Options

src/applications/dashboard/paneltype/PhabricatorDashboardPanelType.php

View Options

src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php

View Options

src/applications/dashboard/storage/PhabricatorDashboardPanel.php

View Options

src/applications/search/controller/PhabricatorApplicationSearchController.php

View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Add a "Customize Query" action to query panels to make it easier to make minor query adjustmentsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48846

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

src/applications/dashboard/paneltype/PhabricatorDashboardPanelType.php

src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php

src/applications/dashboard/storage/PhabricatorDashboardPanel.php

src/applications/search/controller/PhabricatorApplicationSearchController.php

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Add a "Customize Query" action to query panels to make it easier to make minor query adjustments
ClosedPublic
Actions

Revision Contents
Changeset List