Page MenuHomePhabricator
Differential D20464

Remove "--force-autoclose" from "bin/repository reparse"
ClosedPublic
Actions

Authored by epriestley on Apr 22 2019, 11:10 PM.
Tags
None
Referenced Files
F18100461: D20464.id.diff
Sat, Aug 9, 11:54 AM
F17969891: D20464.id48818.diff
Fri, Aug 1, 2:29 PM
F17841731: D20464.id.diff
Sat, Jul 26, 10:47 PM
F17809586: D20464.diff
Fri, Jul 25, 4:57 PM
F17724459: D20464.diff
Jul 18 2025, 12:47 PM
Unknown Object (File)
Jun 5 2025, 4:21 PM
Unknown Object (File)
May 31 2025, 8:30 AM
Unknown Object (File)
May 26 2025, 1:04 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs"
Commits
rP45b9859f0229: Remove "--force-autoclose" from "bin/repository reparse"
Summary

Depends on D20463. Ref T13277. This flag was added some time before 2015 and I don't think I've ever used it. Just get rid of it.

Test Plan

Grepped for force-autoclose, forceAutoclose, AUTOCLOSE_FORCED.

Diff Detail

Repository
rP Phabricator
Branch
audit7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22690
Build 31100: Run Core Tests
Build 31099: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 22 2019, 11:10 PM
Harbormaster completed remote builds in B22690: Diff 48818.Apr 22 2019, 11:11 PM
epriestley requested review of this revision.Apr 22 2019, 11:11 PM
epriestley added inline comments.Apr 22 2019, 11:17 PM
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
175–178

(This was really mooted by the last change; there's a longer explanatory comment in the new worker now.)

epriestley added a child revision: D20465: Remove nearly all remaining references to "Autoclose".Apr 23 2019, 12:12 AM
amckinley accepted this revision.Apr 24 2019, 12:32 AM
This revision is now accepted and ready to land.Apr 24 2019, 12:32 AM
Closed by commit rP45b9859f0229: Remove "--force-autoclose" from "bin/repository reparse" (authored by epriestley). · Explain WhyApr 24 2019, 3:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
editor/
6 lines
repository/
management/
8 lines
storage/
1 line
worker/
commitmessageparser/
15 lines

Diff 48818

View Options

src/applications/diffusion/editor/DiffusionCommitEditEngine.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementReparseWorkflow.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Loading...
Phabricator · Built by Phacility